Add macOS support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supereg
commented
Feb 16, 2024
Supereg
commented
Feb 16, 2024
Tests/UITests/TestAppUITests/SpeziPersonalInfo/PersonalInfoViewsTests.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 79.89% 79.87% -0.01%
==========================================
Files 39 39
Lines 1208 1222 +14
==========================================
+ Hits 965 976 +11
- Misses 243 246 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Thank you for all the improvements; this looks great @Supereg 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add macOS support
♻️ Current situation & Problem
This PR updates the UITests and TestApp to run in macOS. Sadly we currently can't really run UI tests on macOS without the requirement to sign the application.
Additionally, this PR upgrade the XCTestExtensions version with updated support for visionOS and macOS.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
We restructured to CI configuration to align better with the current styling guides.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: