Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure valid input is reported instantly #23

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 9, 2023

Ensure valid input is reported instantly

♻️ Current situation & Problem

Currently, every change in input is debounced by the ValidationEngine. This PR optimizes the user experience by showing valid state instantly. So a user can be more confident on when valid input was entered.

⚙️ Release Notes

  • Ensure valid input is reported instantly to improve user experience.

📚 Documentation

  • Documentation was updated to reflect this behavioral change.

✅ Testing

This PR adds a unit tests to ensure debounce is applied as expected.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer November 9, 2023 18:42
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #23 (de470a2) into main (5cef298) will increase coverage by 0.46%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   77.29%   77.74%   +0.46%     
==========================================
  Files          34       34              
  Lines        1061     1069       +8     
==========================================
+ Hits          820      831      +11     
+ Misses        241      238       -3     
Files Coverage Δ
Sources/SpeziValidation/ValidationEngine.swift 93.83% <100.00%> (+4.79%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cef298...de470a2. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great @Supereg!

Great to see this addition in a next release 🚀

@Supereg Supereg merged commit eac4430 into main Nov 10, 2023
7 checks passed
@Supereg Supereg deleted the feature/validation-debounce-optimization branch November 10, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants