Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out Static Analysis Jobs into separate workflow file #90

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 12, 2024

Split out Static Analysis Jobs into separate workflow file

♻️ Current situation & Problem

Currently, all of our static analysis jobs are contained in the "Build and Test" workflow file. This workflow is also executed before we deploy to TestFlight. Due to missing Swift 6 support, the CodeQL is failing. We decided to leave the CodeQL Job in place nonetheless and made it a non-requirement for pull requests. However, the job is still required to succeed for the iOS deployment job to be executed.

This PR splits out all static analysis jobs into a separate workflow file "Pull Request", similar to the setup that we have in our Spezi framework repositories. This allows us to not have static analysis prevent iOS deployments. For example a code style issue caught by SwiftLint (however that should happen with our current branch protection rules) won't prevent a deployment. Most notably our currently failing CodeQL job isn't preventing deployments for now.

⚙️ Release Notes

  • Break out static analysis jobs into a separate workflow file.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Nov 12, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg!

I used the chance to also improve the build concurrency and smaller changes. Feel free to merge the PR if you agree with the changes 👍

@Supereg
Copy link
Member Author

Supereg commented Nov 12, 2024

Thank you @Supereg!

I used the chance to also improve the build concurrency and smaller changes. Feel free to merge the PR if you agree with the changes 👍

Thanks for adding the concurrency configuration. Will definitely help to reduce some of the build times and helps to freen up runner more quickly. Will merge once CI completes 👍

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (fed2d72) to head (8676b99).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files          21       21           
  Lines         688      688           
=======================================
  Hits          598      598           
  Misses         90       90           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed2d72...8676b99. Read the comment docs.

@Supereg Supereg merged commit 070074c into main Nov 12, 2024
9 of 10 checks passed
@Supereg Supereg deleted the fix/linting-setup-beta-deployment branch November 12, 2024 20:53
@Supereg Supereg mentioned this pull request Nov 12, 2024
1 task
Supereg added a commit that referenced this pull request Nov 12, 2024
# Fix Deployment Workflow

## ♻️ Current situation & Problem
#90 broke the beta deployment workflow as the workflow file was renamed
and forgotten to be updated in the beta deployment workflow. Fixed by
this PR.

## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants