-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out Static Analysis Jobs into separate workflow file #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Supereg!
I used the chance to also improve the build concurrency and smaller changes. Feel free to merge the PR if you agree with the changes 👍
Thanks for adding the concurrency configuration. Will definitely help to reduce some of the build times and helps to freen up runner more quickly. Will merge once CI completes 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 86.92% 86.92%
=======================================
Files 21 21
Lines 688 688
=======================================
Hits 598 598
Misses 90 90 Continue to review full report in Codecov by Sentry.
|
# Fix Deployment Workflow ## ♻️ Current situation & Problem #90 broke the beta deployment workflow as the workflow file was renamed and forgotten to be updated in the beta deployment workflow. Fixed by this PR. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Split out Static Analysis Jobs into separate workflow file
♻️ Current situation & Problem
Currently, all of our static analysis jobs are contained in the "Build and Test" workflow file. This workflow is also executed before we deploy to TestFlight. Due to missing Swift 6 support, the CodeQL is failing. We decided to leave the CodeQL Job in place nonetheless and made it a non-requirement for pull requests. However, the job is still required to succeed for the iOS deployment job to be executed.
This PR splits out all static analysis jobs into a separate workflow file "Pull Request", similar to the setup that we have in our Spezi framework repositories. This allows us to not have static analysis prevent iOS deployments. For example a code style issue caught by SwiftLint (however that should happen with our current branch protection rules) won't prevent a deployment. Most notably our currently failing CodeQL job isn't preventing deployments for now.
⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: