Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI updates for the ScheduleView #73

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Mar 19, 2024

Fix UI updates for the ScheduleView

♻️ Current situation & Problem

Currently, the schedule view is re-rendered based on equatable conformance and on first appearance. This is not ideal, as the task modifier is only executed once on appearance (which is not the equivalent to the ScenePhase).
This restructures the schedule view to make sure all changes are observed.

⚙️ Release Notes

  • Fix view updates of Schedule View.
  • Update dependencies.
  • Support iPad layout.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Sorry, something went wrong.

@Supereg Supereg requested a review from PSchmiedmayer March 19, 2024 17:31
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.52%. Comparing base (97635ac) to head (75db0a7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   80.54%   80.52%   -0.01%     
==========================================
  Files          31       31              
  Lines         976      965      -11     
==========================================
- Hits          786      777       -9     
+ Misses        190      188       -2     
Files Coverage Δ
TemplateApplication/Schedule/ScheduleView.swift 83.79% <100.00%> (+0.26%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97635ac...75db0a7. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates; looks great @Supereg!

@PSchmiedmayer PSchmiedmayer merged commit 226feac into main Mar 22, 2024
7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the fix/schedule-view-updates branch March 22, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants