Updated Account Setup and new Account Editing Functionality #35

Supereg · 2023-09-02T16:43:57Z

Updated Account Setup and new Account Editing Functionality

♻️ Current situation & Problem

There is an upcoming release of SpeziAccount that restructures and simplifies account setup procedure. Further, it adds a new Account Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a user account (e.g. as the standard expects a user account for all operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases that broke due to the latest accessibility improvements in some dependencies.

For more information see:

⚙️ Release Notes

Newly designed Account Setup experience
New Account Editing Functionality
Support complete removal of user data

📚 Documentation

In code documentation was adjusted.

✅ Testing

Tests were updated to cover new vectors.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

I agree to follow the Code of Conduct and Contributing Guidelines.

Supereg · 2023-09-02T16:51:43Z

~~This is currently blocked by StanfordSpezi/SpeziOnboarding#21~~

see StanfordSpezi/SpeziAccount#23

codecov · 2023-09-20T21:37:02Z

Codecov Report

Merging #35 (0a6b981) into main (d310ca1) will increase coverage by 0.82%.
The diff coverage is 92.83%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   80.86%   81.68%   +0.82%     
==========================================
  Files          30       32       +2     
  Lines         815      846      +31     
==========================================
+ Hits          659      691      +32     
+ Misses        156      155       -1

Files Changed	Coverage Δ
...n/Onboarding/OnboardingFlow+PreviewSimulator.swift	`0.00% <0.00%> (ø)`
...tion/Schedule/TemplateApplicationTaskContext.swift	`43.75% <66.67%> (ø)`
TemplateApplication/Account/AccountSheet.swift	`78.95% <78.95%> (ø)`
...plateApplication/TemplateApplicationStandard.swift	`37.65% <85.00%> (+3.92%)`	⬆️
TemplateApplication/MockUpload/MockUpload.swift	`92.31% <87.50%> (-7.69%)`	⬇️
...emplateApplication/Schedule/EventContextView.swift	`90.91% <87.50%> (-1.19%)`	⬇️
TemplateApplication/Schedule/ScheduleView.swift	`86.91% <88.89%> (+1.38%)`	⬆️
...eApplication/Account/AccountRequiredModifier.swift	`96.16% <96.16%> (ø)`
TemplateApplication/Account/AccountButton.swift	`100.00% <100.00%> (ø)`
...mplateApplication/Account/AccountRequiredKey.swift	`100.00% <100.00%> (ø)`
... and 12 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d310ca1...0a6b981. Read the comment docs.

Supereg · 2023-09-20T22:18:49Z

We still want to incorporate StanfordSpezi/SpeziAccount#24

EDIT: ✅

PSchmiedmayer

Thank you for the improvements @Supereg, great to see the new account module in the Template Application! 🚀

I only had a comment to reuse the account button across the different tabs to display it in a consistent position. Apart from this I am happy to see the PR being merged 👍

TemplateApplication/Schedule/ScheduleView.swift

…Spezi#35) There is an upcoming release of SpeziAccount that restructures and simplifies account setup procedure. Further, it adds a new Account Overview that allows you to view and edit your active account details. While it might not be required for all projects, we currently force a user account (e.g. as the standard expects a user account for all operations) even if the user decides to log out. Furthermore, we restore test case functionality for some tests cases that broke due to the latest accessibility improvements in some dependencies. For more information see: * StanfordSpezi/SpeziAccount#7 * StanfordSpezi/SpeziFirebase#8 * Newly designed Account Setup experience * New Account Editing Functionality * Support complete removal of user data In code documentation was adjusted. Tests were updated to cover new vectors. By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).

…Spezi#35) # Updated Account Setup and new Account Editing Functionality ## ♻️ Current situation & Problem There is an upcoming release of SpeziAccount that restructures and simplifies account setup procedure. Further, it adds a new Account Overview that allows you to view and edit your active account details. While it might not be required for all projects, we currently force a user account (e.g. as the standard expects a user account for all operations) even if the user decides to log out. Furthermore, we restore test case functionality for some tests cases that broke due to the latest accessibility improvements in some dependencies. For more information see: * StanfordSpezi/SpeziAccount#7 * StanfordSpezi/SpeziFirebase#8 ## ⚙️ Release Notes * Newly designed Account Setup experience * New Account Editing Functionality * Support complete removal of user data ## 📚 Documentation In code documentation was adjusted. ## ✅ Testing Tests were updated to cover new vectors. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).

…Spezi#35) There is an upcoming release of SpeziAccount that restructures and simplifies account setup procedure. Further, it adds a new Account Overview that allows you to view and edit your active account details. While it might not be required for all projects, we currently force a user account (e.g. as the standard expects a user account for all operations) even if the user decides to log out. Furthermore, we restore test case functionality for some tests cases that broke due to the latest accessibility improvements in some dependencies. For more information see: * StanfordSpezi/SpeziAccount#7 * StanfordSpezi/SpeziFirebase#8 * Newly designed Account Setup experience * New Account Editing Functionality * Support complete removal of user data In code documentation was adjusted. Tests were updated to cover new vectors. By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).

Supereg added 2 commits September 2, 2023 16:30

Resolved changes

5d2f206

Initial work to upgrade to new SpeziAccount library

f9dd695

Supereg added 5 commits September 15, 2023 10:16

Pump all dependencies to their release version

2651afc

Update resolved

166e603

Implement SepziAccount

4596ad6

Fix REUSE

152e1ee

Fix tests

b594f4d

Fully test the account sheet

2339f69

Swiftlint

d592474

Supereg changed the title ~~Upgrade SpeziAccount~~ Updated Account Setup and new Account Editing Functionality Sep 20, 2023

Delete all user data on removal

3b043bc

Supereg marked this pull request as ready for review September 20, 2023 22:50

Reenable firebase disable

3b9c4f8

Supereg requested a review from PSchmiedmayer September 20, 2023 22:55

Supereg added the enhancement New feature or request label Sep 20, 2023

Supereg added 4 commits September 21, 2023 01:05

Update CONTRIBUTORS.md

2f0a7f6

Simplfy views through modifiers

a7f9f62

Fix swiftlint

5cd9d9f

compilation

c84cfa0

PSchmiedmayer approved these changes Sep 22, 2023

View reviewed changes

TemplateApplication/Schedule/ScheduleView.swift Outdated Show resolved Hide resolved

PSchmiedmayer assigned Supereg Sep 22, 2023

Display account button in all views

0a6b981

Supereg enabled auto-merge (squash) September 22, 2023 23:29

Supereg merged commit 162260a into main Sep 23, 2023

Supereg deleted the feature/spezi-account-upgrade branch September 23, 2023 00:13

Supereg mentioned this pull request Nov 6, 2023

Logout Button Allows to Skip Account Setup #21

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Account Setup and new Account Editing Functionality #35

Updated Account Setup and new Account Editing Functionality #35

Supereg commented Sep 2, 2023 •

edited

Loading

Supereg commented Sep 2, 2023 •

edited

Loading

codecov bot commented Sep 20, 2023 •

edited

Loading

Supereg commented Sep 20, 2023 •

edited

Loading

PSchmiedmayer left a comment

Updated Account Setup and new Account Editing Functionality #35

Updated Account Setup and new Account Editing Functionality #35

Conversation

Supereg commented Sep 2, 2023 • edited Loading

Updated Account Setup and new Account Editing Functionality

♻️ Current situation & Problem

⚙️ Release Notes

📚 Documentation

✅ Testing

📝 Code of Conduct & Contributing Guidelines

Supereg commented Sep 2, 2023 • edited Loading

codecov bot commented Sep 20, 2023 • edited Loading

Codecov Report

Supereg commented Sep 20, 2023 • edited Loading

PSchmiedmayer left a comment

Choose a reason for hiding this comment

Supereg commented Sep 2, 2023 •

edited

Loading

Supereg commented Sep 2, 2023 •

edited

Loading

codecov bot commented Sep 20, 2023 •

edited

Loading

Supereg commented Sep 20, 2023 •

edited

Loading