Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to iOS 17 and new Spezi version #16

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 7, 2023

Update to iOS 17 and new Spezi version

♻️ Current situation & Problem

This PR prepares SpeziStorage for the upcoming version of Spezi and replaces ObservableObject with Observable.

⚙️ Release Notes

  • Update to iOS 17
  • Compatibility with upcoming Spezi release
  • Breaking: Replaces observable object with Observable.

📚 Documentation

Documentation was updated.

✅ Testing

Affected test code was updated.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer November 7, 2023 01:48
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great job!

CONTRIBUTORS.md Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #16 (3ac67e4) into main (d3db2a6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files           6        6           
  Lines         431      431           
=======================================
  Hits          395      395           
  Misses         36       36           
Files Coverage Δ
Sources/SpeziLocalStorage/LocalStorage.swift 89.43% <ø> (ø)
Sources/SpeziSecureStorage/SecureStorage.swift 93.34% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3db2a6...3ac67e4. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Supereg Supereg enabled auto-merge (squash) November 8, 2023 21:46
@Supereg Supereg merged commit e9be3c2 into main Nov 8, 2023
8 checks passed
@Supereg Supereg deleted the feature/upgrade-spezi branch November 8, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants