Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ORKOrderedTaskView with new ResearchKit one #23

Merged
merged 5 commits into from
Feb 24, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Feb 24, 2024

Replace ORKOrderedTaskView with new ResearchKit one

♻️ Current situation & Problem

This PR updates to our latest version of ResearchKit and replaces the internal ORKOrderedTaskView implementation with the new one available in ResearchKitSwiftUI.

⚙️ Release Notes

  • Updated to new ResearchKit version

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg changed the title Reuse new views Replace ORKOrderedTaskView with new ResearchKit one Feb 24, 2024
@Supereg Supereg marked this pull request as ready for review February 24, 2024 00:29
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.11%. Comparing base (fac0bb0) to head (2812b70).

❗ Current head 2812b70 differs from pull request most recent head 09c92ac. Consider uploading reports for the commit 09c92ac to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   87.02%   85.11%   -1.90%     
==========================================
  Files           2        1       -1     
  Lines          77       47      -30     
==========================================
- Hits           67       40      -27     
+ Misses         10        7       -3     
Files Coverage Δ
Sources/SpeziQuestionnaire/QuestionnaireView.swift 85.11% <88.24%> (-0.60%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac0bb0...09c92ac. Read the comment docs.

@Supereg Supereg enabled auto-merge (squash) February 24, 2024 00:51
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. I had one comment that it would be great to discuss before we merge the PR.

Sources/SpeziQuestionnaire/QuestionnaireView.swift Outdated Show resolved Hide resolved
@Supereg
Copy link
Member Author

Supereg commented Feb 24, 2024

Not sure why codecov doesn't report any updates. Might we just merge?

@Supereg Supereg merged commit f25580e into main Feb 24, 2024
8 checks passed
@Supereg Supereg deleted the feature/researchkit-upgrade branch February 24, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants