-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup, Swift 6, Consent Contraint and SignatureView improvements #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this 🚀 ... wondering if we should combine this with the #59 that @pauljohanneskraft is working on? I saw that he did a similar change in there as well as additional elements. We might to merge this in a single effort?
73f34f4
to
eab5689
Compare
…nto feature/signature-view-access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements and getting this across the finish line @philippzagar!
Sources/SpeziOnboarding/ConsentView/ConsentDocumentExport+Export.swift
Outdated
Show resolved
Hide resolved
@PSchmiedmayer The PR got a bit bigger than expected, there was just tons of cleanup to be done within the Consent logic. Still not perfect, but way better than before. |
Sounds great; thank you @philippzagar! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the improvements @philippzagar!
Only had a few small comments; happy to see it merged once all the CI tests are passing 🚀
Very nice @philippzagar! Thank you for the foundations @Supereg! 🚀 |
Cleanup, Swift 6, Consent Contraint and SignatureView improvements
♻️ Current situation & Problem
The repo needed some cleanup and improvements. Similar, the
SignatureView
should be able to be used individually.⚙️ Release Notes
OnboardingDateSource
andConsentConstraint
were removed in favor of a way simple export-handeling closure on theOnboardingConsentView
.SignatureView
is nowpublic
and has a date associated with it (also exported in the PDF)OnboardingConsentView
now has proper progress indication for theaction
closure.📚 Documentation
Some doc fixes and improvements.
✅ Testing
Manual testing and UI tests
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: