Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, Swift 6, Consent Contraint and SignatureView improvements #60

Merged
merged 26 commits into from
Jan 29, 2025

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 23, 2024

Cleanup, Swift 6, Consent Contraint and SignatureView improvements

♻️ Current situation & Problem

The repo needed some cleanup and improvements. Similar, the SignatureView should be able to be used individually.

⚙️ Release Notes

  • Swift 6 language mode
  • The OnboardingDateSource and ConsentConstraint were removed in favor of a way simple export-handeling closure on the OnboardingConsentView.
  • SignatureView is now public and has a date associated with it (also exported in the PDF)
  • OnboardingConsentView now has proper progress indication for the action closure.
  • General cleanup of the application, as quite some dead code / inconsistencies has been accumulated, especially in the consent export part.

📚 Documentation

Some doc fixes and improvements.

✅ Testing

Manual testing and UI tests

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this 🚀 ... wondering if we should combine this with the #59 that @pauljohanneskraft is working on? I saw that he did a similar change in there as well as additional elements. We might to merge this in a single effort?

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 74.75000% with 101 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (e3b8d50) to head (bfb2528).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ources/SpeziOnboarding/OnboardingConsentView.swift 41.18% 40 Missing ⚠️
.../SpeziOnboarding/Consent/Views/SignatureView.swift 44.12% 19 Missing ⚠️
...ng/Consent/Views/OnboardingConsentView+Error.swift 0.00% 18 Missing ⚠️
...peziOnboarding/Consent/Views/ConsentDocument.swift 83.02% 9 Missing ⚠️
...arding/Consent/Export/ConsentDocument+Export.swift 82.50% 7 Missing ⚠️
...arding/Consent/Views/SignatureViewBackground.swift 87.04% 7 Missing ⚠️
...t/ConsentDocumentExportRepresentation+Render.swift 99.10% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   71.06%   73.80%   +2.75%     
==========================================
  Files          27       24       -3     
  Lines        1323     1328       +5     
==========================================
+ Hits          940      980      +40     
+ Misses        383      348      -35     
Files with missing lines Coverage Δ
...iOnboarding/Consent/ConsentViewState+Binding.swift 100.00% <ø> (ø)
...ntDocumentExportRepresentation+Configuration.swift 65.00% <100.00%> (ø)
...t/Export/ConsentDocumentExportRepresentation.swift 100.00% <100.00%> (ø)
...nsent/Views/OnboardingConsentView+ShareSheet.swift 0.00% <ø> (ø)
...ing/OnboardingFlow/IllegalOnboardingStepView.swift 0.00% <ø> (ø)
...rdingFlow/OnboardingIdentifiableViewModifier.swift 100.00% <ø> (ø)
...eziOnboarding/OnboardingFlow/OnboardingStack.swift 100.00% <ø> (ø)
...es/SpeziOnboarding/OnboardingInformationView.swift 87.24% <ø> (+37.24%) ⬆️
Sources/SpeziOnboarding/OnboardingView.swift 58.58% <ø> (ø)
...t/ConsentDocumentExportRepresentation+Render.swift 99.10% <99.10%> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b8d50...bfb2528. Read the comment docs.

@Supereg Supereg force-pushed the feature/signature-view-access branch from 73f34f4 to eab5689 Compare January 22, 2025 21:37
@philippzagar philippzagar changed the title Allow to use SignatureView Cleanup, Swift 6 and SignatureView improvements Jan 22, 2025
@philippzagar philippzagar self-assigned this Jan 22, 2025
@philippzagar philippzagar added the enhancement New feature or request label Jan 22, 2025
@philippzagar philippzagar marked this pull request as ready for review January 22, 2025 23:54
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements and getting this across the finish line @philippzagar!

Package.swift Outdated Show resolved Hide resolved
Sources/SpeziOnboarding/SignatureView.swift Show resolved Hide resolved
Sources/SpeziOnboarding/ConsentView/ConsentViewState.swift Outdated Show resolved Hide resolved
@philippzagar
Copy link
Member

philippzagar commented Jan 24, 2025

@PSchmiedmayer The PR got a bit bigger than expected, there was just tons of cleanup to be done within the Consent logic. Still not perfect, but way better than before.
There is still quite a bit to do within the overall SpeziOnboarding repo, but I'll do that as soon as we split up the single target into two.

@PSchmiedmayer
Copy link
Member

Sounds great; thank you @philippzagar!

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the improvements @philippzagar!

Only had a few small comments; happy to see it merged once all the CI tests are passing 🚀

Sources/SpeziOnboarding/OnboardingDataSource.swift Outdated Show resolved Hide resolved
Sources/SpeziOnboarding/Resources/Localizable.xcstrings Outdated Show resolved Hide resolved
@philippzagar philippzagar changed the title Cleanup, Swift 6 and SignatureView improvements Cleanup, Swift 6, Consent Contraint and SignatureView improvements Jan 26, 2025
@philippzagar philippzagar merged commit a7cc789 into main Jan 29, 2025
17 checks passed
@philippzagar philippzagar deleted the feature/signature-view-access branch January 29, 2025 00:14
@PSchmiedmayer
Copy link
Member

Very nice @philippzagar! Thank you for the foundations @Supereg! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants