Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Button Title Dependent on the Medication Modification State #6

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

PSchmiedmayer
Copy link
Member

Make Button Title Dependent on the Medication Modification State

♻️ Current situation & Problem

  • Feedback we received from users of the Medication Module:

Upon clicking medication settings, the only way a user can go back is either by clicking "cancel" or swiping down from the upper third of the screen. Propose changing "cancel" to "close." Important to leave "cancel" when adding a new medication as in that situation you would be cancelling the action.

⚙️ Release Notes

  • Show "close" instead of "cancel" in the case that a medication has not yet been changed.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jan 23, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8aa11bd) 49.15% compared to head (6330bf8) 49.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   49.15%   49.50%   +0.36%     
==========================================
  Files          20       20              
  Lines         989      996       +7     
==========================================
+ Hits          486      493       +7     
  Misses        503      503              
Files Coverage Δ
Sources/SpeziMedication/MedicationSettings.swift 88.58% <100.00%> (+0.61%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa11bd...6330bf8. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit b35aa26 into main Jan 23, 2024
9 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/buttonTitle branch January 23, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant