Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: iOS 18.1 / Swift 6 compatibility, Fix Deprecations, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies #74

Merged
merged 28 commits into from
Nov 13, 2024

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Nov 12, 2024

Maintenance: iOS 18.1 / Swift 6 compatibility, Fix Deprecations, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies

♻️ Current situation & Problem

Repo wasn't really maintained in the last months, therefore lots of things became a bit out of date.

⚙️ Release Notes

  • iOS 18.1 / Swift 6 compatibility
  • Fix Deprecations
  • Bump Fog Node JS dependencies
  • Rudimentary Fog Node CI testing

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

dependabot bot and others added 16 commits September 21, 2024 06:53
Bumps [body-parser](https://github.com/expressjs/body-parser) to 1.20.3 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](expressjs/body-parser@1.20.2...1.20.3)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: body-parser
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [serve-static](https://github.com/expressjs/serve-static) to 1.16.2 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `serve-static` from 1.15.0 to 1.16.2
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...v1.16.2)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: serve-static
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [send](https://github.com/pillarjs/send) to 0.19.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `send` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](pillarjs/send@0.18.0...0.19.0)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: send
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cookie](https://github.com/jshttp/cookie) to 0.7.1 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `cookie` from 0.6.0 to 0.7.1
- [Release notes](https://github.com/jshttp/cookie/releases)
- [Commits](jshttp/cookie@v0.6.0...v0.7.1)

Updates `express` from 4.19.2 to 4.21.1
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](expressjs/express@4.19.2...4.21.1)

---
updated-dependencies:
- dependency-name: cookie
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.10 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10)

Updates `express` from 4.19.2 to 4.21.1
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](expressjs/express@4.19.2...4.21.1)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…auth/multi-9423f4c335' into feat/dependabot-bumps
…auth/multi-d66d039ac5' into feat/dependabot-bumps
…auth/multi-cf87d80143' into feat/dependabot-bumps
…auth/multi-9f37c16f8f' into feat/dependabot-bumps
…auth/multi-8a99b2c3f2' into feat/dependabot-bumps
@philippzagar philippzagar self-assigned this Nov 12, 2024
@PSchmiedmayer
Copy link
Member

@philippzagar Thank you for working on this and merging it in a single PR!

I see that that there are a lot of iOS elements failing, let me know if you need any help from someone there. I think the issues might be related to some Xcode updates and Simulators available on the runners?

@philippzagar
Copy link
Member Author

philippzagar commented Nov 13, 2024

I see that that there are a lot of iOS elements failing, let me know if you need any help from someone there. I think the issues might be related to some Xcode updates and Simulators available on the runners?

Currently investigating that, you were right, the issue seems to be in the UI tests with the selection of TextFields vs TextViews, seems to be an iOS 18 (or 18.1?) change.
Will let you know as soon as the PR is ready!

@philippzagar philippzagar changed the title Bump Fog Node JS Dependencies iOS 18 compatibility, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies Nov 13, 2024
@philippzagar philippzagar changed the title iOS 18 compatibility, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies Maintenance: iOS 18 compatibility, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies Nov 13, 2024
@philippzagar philippzagar changed the title Maintenance: iOS 18 compatibility, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies Maintenance: iOS 18 / Swift 6 compatibility, Fix Deprecations, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.24%. Comparing base (a4ee2da) to head (556fccb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   36.24%   36.24%           
=======================================
  Files          64       64           
  Lines        2503     2503           
=======================================
  Hits          907      907           
  Misses       1596     1596           
Files with missing lines Coverage Δ
Sources/SpeziLLM/LLMPlatformBuilder.swift 100.00% <100.00%> (ø)
Sources/SpeziLLM/Models/LLMError.swift 0.00% <ø> (ø)
Sources/SpeziLLM/Views/LLMChatView.swift 92.11% <ø> (ø)
...penAI/Configuration/LLMOpenAIModelParameters.swift 100.00% <ø> (ø)
.../FunctionCalling/LLMFunctionParameterWrapper.swift 37.50% <ø> (ø)
Sources/SpeziLLMOpenAI/LLMOpenAIPlatform.swift 36.37% <ø> (ø)
Sources/SpeziLLMOpenAI/LLMOpenAITokenSaver.swift 56.25% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ee2da...556fccb. Read the comment docs.

@philippzagar
Copy link
Member Author

@PSchmiedmayer So, PR should be ready now, in general I did a bit of maintenance work in the PR.
Most of the retroactive conformances (dangerous!) will soon be redudndant as soon as #64 is merged!

@philippzagar philippzagar added the enhancement New feature or request label Nov 13, 2024
@philippzagar
Copy link
Member Author

@PSchmiedmayer Could you grant me admin access to the repo? Then I can e.g. set new CI jobs as required by this change on my own.

@philippzagar philippzagar changed the title Maintenance: iOS 18 / Swift 6 compatibility, Fix Deprecations, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies Maintenance: iOS 18.1 / Swift 6 compatibility, Fix Deprecations, Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies Nov 13, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; looks great @philippzagar!

@philippzagar philippzagar merged commit c64983b into main Nov 13, 2024
19 checks passed
@philippzagar philippzagar deleted the feat/dependabot-bumps branch November 13, 2024 21:54
paulhdk added a commit that referenced this pull request Dec 16, 2024
…mentary Fog Node CI testing, Bump Fog Node JS Dependencies (#74)

Rudimentary Fog Node CI testing, Bump Fog Node JS Dependencies

Repo wasn't really maintained in the last months, therefore lots of
things became a bit out of date.

- iOS 18.1 / Swift 6 compatibility
- Fix Deprecations
- Bump Fog Node JS dependencies
- Rudimentary Fog Node CI testing

--

--

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Paul Schmiedmayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants