-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifies setData extensions #38
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 61.39% 63.02% +1.63%
==========================================
Files 19 19
Lines 1155 1122 -33
==========================================
- Hits 709 707 -2
+ Misses 446 415 -31
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me; thank you @vishnuravi for the simplification here!
Thank you @vishnuravi for the added tests! |
Was there any more detail why this crash occurred. Particularly the crash message would be interesting. |
Simplifies setData extensions
♻️ Current situation & Problem
This setData extensions can be simplified to remove the continuations as the Firebase SDK now provides an async function for saving a dictionary to Firestore. This may also resolve the bug reported in #37, as the continuation is now removed.
⚙️ Release Notes
Updates the setData extensions to use the async function as described above.
📚 Documentation
The function signatures are unchanged and no changes to documentation are required.
✅ Testing
Additional tests have been added.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: