Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firestore Account Storage Create Update Override #33

Merged
merged 3 commits into from
May 31, 2024

Conversation

PSchmiedmayer
Copy link
Member

Fix Firestore Account Storage Create Update Override

♻️ Current situation & Problem

  • Upon sign up the current state of the user document is overwritten. It could already be defined if e.g. the user was pre-created using a dashboard or a cloud function on sign up.

⚙️ Release Notes

  • Sets the merge flag to fix an Firestore account storage create update override.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the bug Something isn't working label May 31, 2024
@PSchmiedmayer PSchmiedmayer requested a review from Supereg May 31, 2024 04:20
@PSchmiedmayer PSchmiedmayer self-assigned this May 31, 2024
Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🚀

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (16c1c75) to head (71744bc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files          19       19           
  Lines        1151     1151           
=======================================
  Hits          693      693           
  Misses        458      458           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c1c75...71744bc. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit f05c859 into main May 31, 2024
8 checks passed
@PSchmiedmayer PSchmiedmayer deleted the fixFirestoreAccountStorageCreate branch May 31, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants