Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation catalogs for all targets #26

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jan 10, 2024

Add documentation catalogs for all targets

♻️ Current situation & Problem

This PR adds documentation catalogs for all targets and upgrades all dependencies to their latest 1.0 releases.

⚙️ Release Notes

  • Add documentation catalogs for all targets.
  • Upgrade all dependencies to their latest 1.0 releases.
  • Fixed an issue where Account association was removed when no network coverage is available

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer January 10, 2024 06:42
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates and documentation improvements! Feel free to merge the PR once all the checks are passing 🚀

@Supereg
Copy link
Member Author

Supereg commented Jan 10, 2024

This PR made some additional changes to update the README. This was inspired by the current draft PR #22, making it obsolete.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (db46d60) 59.91% compared to head (05d6534) 60.04%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   59.91%   60.04%   +0.14%     
==========================================
  Files          19       19              
  Lines        1065     1071       +6     
==========================================
+ Hits          638      643       +5     
- Misses        427      428       +1     
Files Coverage Δ
...FirebaseAccount/FirebaseAccountConfiguration.swift 88.10% <ø> (ø)
...ziFirebaseConfiguration/ConfigureFirebaseApp.swift 100.00% <ø> (ø)
Sources/SpeziFirestore/Firestore.swift 72.73% <ø> (ø)
.../SpeziFirebaseAccount/Models/FirebaseContext.swift 91.79% <85.72%> (-0.25%) ⬇️
Sources/SpeziFirestore/FirestoreErrorCode.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db46d60...05d6534. Read the comment docs.

@Supereg Supereg merged commit ca1edf6 into main Jan 10, 2024
8 checks passed
@Supereg Supereg deleted the feature/spezi-1.0-and-docs branch January 10, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants