Introduce FirestoreAccountStorage #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSchmiedmayer
approved these changes
Nov 15, 2023
Sources/SpeziFirebaseAccountStorage/FirestoreAccountStorage.swift
Outdated
Show resolved
Hide resolved
Sources/SpeziFirebaseAccountStorage/FirestoreAccountStorage.swift
Outdated
Show resolved
Hide resolved
Sources/SpeziFirebaseAccountStorage/FirestoreAccountStorage.swift
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 3.28% 59.99% +56.72%
==========================================
Files 19 19
Lines 1070 1072 +2
==========================================
+ Hits 35 643 +608
+ Misses 1035 429 -606
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Thank you @Supereg for the additional improvements and merging the PR 🚀 |
1 task
Supereg
added a commit
that referenced
this pull request
Nov 21, 2023
# Rework FirestoreAccountStorage implementation ## ♻️ Current situation & Problem This PR fixes several issues identified within #24. As it turns out, we completely forgot to add testing for this component. This follow-up PR addresses some of the issues and adds proper UI testing. ## ⚙️ Release Notes * Fixes several issues with the `FirestoreAccountStorage` module ## 📚 Documentation -- ## ✅ Testing We added testing for the respective components. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce FirestoreAccountStorage
♻️ Current situation & Problem
This PR introduces the new FirestoreAccountStorage target that allows you to easily implement an AccountStorageStandard using Firestore.
⚙️ Release Notes
FirestoreAccountStorageto easily storage additional user data in firestore📚 Documentation
Extensive documentation was added.
Further, I noticed that our documentation builds are not up to date in the Swift package index. This is probably due to an outdated spi.yml. This file was updated as part of this PR.
✅ Testing
TBA
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: