Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements for Sign in with Apple #20

Merged
merged 9 commits into from
Oct 27, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 27, 2023

Fixes and improvements for Sign in with Apple

♻️ Current situation & Problem

We recently tried to deploy Sign in with Apple to a live system and found several issues with the current implementation:

  • Nonce generation found to be incompatible with Firebase (they are seemingly unable to handle some special characters)
  • The .firebaseAccount(_:) modifier had issues injecting the AuthorizationController if there was a standard (e.g. notify or storage standard) injected into SpeziAccount
  • Firebase account deletion requires a recent login.

This PR requires StanfordSpezi/SpeziAccount#31 to be merged.

⚙️ Release Notes

Fixes and improvements for Sign in with Apple.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer October 27, 2023 20:32
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #20 (4e3c64f) into main (774c5e3) will decrease coverage by 0.54%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   59.14%   58.60%   -0.54%     
==========================================
  Files          17       17              
  Lines        1023     1053      +30     
==========================================
+ Hits          605      617      +12     
- Misses        418      436      +18     
Files Coverage Δ
...ount/Account Services/FirebaseAccountService.swift 79.02% <100.00%> (-0.25%) ⬇️
...urces/SpeziFirebaseAccount/Utils/CryptoUtils.swift 95.00% <100.00%> (ø)
...Services/FirebaseEmailPasswordAccountService.swift 89.91% <83.34%> (-0.47%) ⬇️
...s/SpeziFirebaseAccount/Utils/FirebaseContext.swift 91.21% <50.00%> (-0.77%) ⬇️
...irebaseAccount/Views/FirebaseAccountModifier.swift 76.48% <53.85%> (-14.43%) ⬇️
...vices/FirebaseIdentityProviderAccountService.swift 30.71% <8.34%> (-0.94%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774c5e3...4e3c64f. Read the comment docs.

@Supereg Supereg enabled auto-merge (squash) October 27, 2023 21:56
@Supereg
Copy link
Member Author

Supereg commented Oct 27, 2023

@PSchmiedmayer would you mind force merging? As we change things in the IdentityProvider, those diff changes are not covered.

@PSchmiedmayer PSchmiedmayer merged commit 187d1ed into main Oct 27, 2023
6 of 7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the fix/sign-in-with-apple branch October 27, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants