-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvements for Sign in with Apple #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
- Coverage 59.14% 58.60% -0.54%
==========================================
Files 17 17
Lines 1023 1053 +30
==========================================
+ Hits 605 617 +12
- Misses 418 436 +18
Continue to review full report in Codecov by Sentry.
|
@PSchmiedmayer would you mind force merging? As we change things in the IdentityProvider, those diff changes are not covered. |
Fixes and improvements for Sign in with Apple
♻️ Current situation & Problem
We recently tried to deploy Sign in with Apple to a live system and found several issues with the current implementation:
.firebaseAccount(_:)
modifier had issues injecting theAuthorizationController
if there was a standard (e.g. notify or storage standard) injected into SpeziAccountThis PR requires StanfordSpezi/SpeziAccount#31 to be merged.
⚙️ Release Notes
Fixes and improvements for Sign in with Apple.
📚 Documentation
--
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: