Resolve feedback

StanfordSpezi · Nov 20, 2023 · 7a3f228 · 7a3f228
1 parent 108ca3f
commit 7a3f228
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/Sources/SpeziFirebaseAccount/Account Services/FirebaseAccountService.swift b/Sources/SpeziFirebaseAccount/Account Services/FirebaseAccountService.swift
@@ -119,7 +119,7 @@ extension FirebaseAccountService {
                 try await changeRequest.commitChanges()
             }
 
-            // non of the above request will trigger our state change listener, therefore just call it manually.
+            // None of the above requests will trigger our state change listener, therefore, we just call it manually.
             try await context.notifyUserSignIn(user: currentUser, for: self)
         } catch let error as NSError {
             Self.logger.error("Received NSError on firebase dispatch: \(error)")

diff --git a/Sources/SpeziFirebaseAccountStorage/FirestoreAccountStorage.swift b/Sources/SpeziFirebaseAccountStorage/FirestoreAccountStorage.swift
@@ -74,10 +74,12 @@ public actor FirestoreAccountStorage: Module, AccountStorageStandard {
 
     private let collection: () -> CollectionReference
 
+
     public init(storeIn collection: @Sendable @autoclosure @escaping () -> CollectionReference) {
         self.collection = collection
     }
 
+
     private func userDocument(for accountId: String) -> DocumentReference {
         collection().document(accountId)
     }

diff --git a/Tests/UITests/TestApp/FirebaseAccountStorage/BiographyKey.swift b/Tests/UITests/TestApp/FirebaseAccountStorage/BiographyKey.swift
@@ -14,6 +14,7 @@ import SwiftUI
 struct BiographyKey: AccountKey {
     typealias Value = String
 
+
     static let name: LocalizedStringResource = "Biography" // we don't bother to translate
     static let category: AccountKeyCategory = .personalDetails
 }
@@ -37,6 +38,7 @@ extension BiographyKey {
     public struct DataEntry: DataEntryView {
         public typealias Key = BiographyKey
 
+
         @Binding private var biography: Value
 
         public init(_ value: Binding<Value>) {

diff --git a/Tests/UITests/TestApp/Shared/FeatureFlags.swift b/Tests/UITests/TestApp/Shared/FeatureFlags.swift
@@ -8,6 +8,7 @@
 
 import Foundation
 
+
 enum FeatureFlags {
     static let accountStorageTests = ProcessInfo.processInfo.arguments.contains("--account-storage")
 }
diff --git a/Tests/UITests/TestAppUITests/FirebaseAccountStorageTests.swift b/Tests/UITests/TestAppUITests/FirebaseAccountStorageTests.swift
@@ -51,7 +51,7 @@ final class FirebaseAccountStorageTests: XCTestCase {
         XCTAssertTrue(app.staticTexts["Biography, Hello Stanford"].waitForExistence(timeout: 2.0))
 
 
-        // NOW TEST ACCOUNT EDIT
+        // TEST ACCOUNT EDIT
         XCTAssertTrue(app.navigationBars.buttons["Edit"].exists)
         app.navigationBars.buttons["Edit"].tap()