Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests FHIRResource and its extensions #28

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

jdisho
Copy link
Collaborator

@jdisho jdisho commented Jan 3, 2025

Write tests for FHIRResource and its extensions.

♻️ Current situation & Problem

The FHIRResource class and its extensions currently have 0% test coverage. We should increase the code coverage as much as possible, to ensure long-term maintainability.

⚙️ Release Notes

  • This PR doesn't change any features. It adds tests for the FHIRResource, FHIRResource+Search, and ResourceProxy+DisplayName.
  • For the FHIRResource+Category tests, it's best to wait until PR FHIRStore actor isolation #26 is merged into the main branch, avoiding any potential conflicts or inconsistencies.

📚 Documentation

Comments are added throughout the code.

✅ Testing

Aim for >90% code coverage, but >80% is acceptable in this case.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@jdisho jdisho added the enhancement New feature or request label Jan 3, 2025
@jdisho jdisho mentioned this pull request Jan 3, 2025
4 tasks
@jdisho jdisho force-pushed the test-fhirresource branch 2 times, most recently from b71333d to d607628 Compare January 3, 2025 15:49
@jdisho jdisho force-pushed the test-fhirresource branch from d607628 to 2fa405c Compare January 3, 2025 15:51
@jdisho jdisho changed the title Write tests for FHIRResource and its extensions. Tests FHIRResource and its extensions. Jan 3, 2025
@jdisho jdisho changed the title Tests FHIRResource and its extensions. Tests FHIRResource and its extensions Jan 3, 2025
@jdisho jdisho assigned jdisho and unassigned philippzagar and LeonNissen Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants