Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only dismiss the measurements sheet when we are saving the last one #12

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Sep 1, 2024

Only dismiss the measurements sheet when we are saving the last one

♻️ Current situation & Problem

This PR address StanfordBDHG/ENGAGE-HF-iOS#79 by only dismissing the recorded measurements sheet only if there aren't any more measurements displayed. This makes it easier for users to save multiple measurements.

⚙️ Release Notes

  • Only dismiss the measurements sheet if the last measurement is saved.
  • Show the last measurement in the closing animation.

📚 Documentation

--

✅ Testing

Existing test validate this behavior.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (cfba769) to head (ee91b92).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cesUI/Measurements/MeasurementsRecordedSheet.swift 75.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   83.78%   83.69%   -0.09%     
==========================================
  Files          55       55              
  Lines        2952     2954       +2     
==========================================
- Hits         2473     2472       -1     
- Misses        479      482       +3     
Files with missing lines Coverage Δ
...cesUI/Measurements/MeasurementsRecordedSheet.swift 92.54% <75.00%> (-2.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfba769...ee91b92. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving this mechanism; looks great!

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Sep 1, 2024
@Supereg Supereg merged commit dc8dcd5 into main Sep 2, 2024
12 checks passed
@Supereg Supereg deleted the fix/easily-save-multiple-measurements branch September 2, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants