Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export of CNPostalAddress #29

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Fix export of CNPostalAddress #29

merged 3 commits into from
Aug 14, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 14, 2024

Fix export of CNPostalAddress

♻️ Current situation & Problem

This issue resolve the @_exported import that was prevented due to the @preconcurrency annotation.

⚙️ Release Notes

  • Fixed an issue for users relying on SpeziContacts to import the Contacts framework.

📚 Documentation

--

✅ Testing

Tests were updated to remove the import.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look at this @Supereg!

Tests/UITests/TestApp/ContactsTestsView.swift Show resolved Hide resolved
@Supereg Supereg linked an issue Aug 14, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (9a7aa7e) to head (be40d91).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files           4        4           
  Lines         319      319           
=======================================
  Hits          251      251           
  Misses         68       68           
Files Coverage Δ
Sources/SpeziContact/Models/Contact.swift 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7aa7e...be40d91. Read the comment docs.

@Supereg Supereg merged commit 8dd7cb4 into main Aug 14, 2024
7 checks passed
@Supereg Supereg deleted the fix/contacts-exported branch August 14, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error with SpeziContact 1.0.1 and CNMutablePostalAddress
2 participants