-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding coding examples for Contact and ContactOption #24
Adding coding examples for Contact and ContactOption #24
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 78.69% 78.69%
=======================================
Files 4 4
Lines 319 319
=======================================
Hits 251 251
Misses 68 68
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @akanshyabhat! 🚀
I had some comments about slightly increasing the example to showcase the usage within a larger context. Feel free to address them and request a new review 🚀
Thank you so much for the feedback @philippzagar! I've updated it accordingly please take a look whenever you can! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments left @akanshyabhat, thanks for incorporating the feedback!
@philippzagar Just addressed these changes! Thank you so much for your patience and time. I really appreciate it! |
@akanshyabhat There are some unresolved discussion items, please resolve them first and then request a review |
So sorry @philippzagar - I forgot to hit the resolve button! They have been resolved now :) I'm not able to re-request a review from my end, so if you could take a look, that would be great! |
Adding coding examples for Contact and ContactOption
♻️ Current situation & Problem
When I was creating a contact for our application, I was unable to see coding examples. These added examples hope to clarify how someone might build and implement these features.
📚 Documentation
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: