Model Account and AccountService as Spezi Module
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supereg
force-pushed
the
feature/account-module
branch
2 times, most recently
from
23376d7 to
0605b23
Compare
Supereg
force-pushed
the
feature/account-module
branch
from
0605b23 to
f45fcf4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 76.12% 73.12% -3.00%
==========================================
Files 116 115 -1
Lines 4020 4065 +45
==========================================
- Hits 3060 2972 -88
- Misses 960 1093 +133
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Supereg
changed the title
Account and AccountService as Spezi Module
PSchmiedmayer
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Nice work; great to see how all these things are starting to interconnect; great job @Supereg!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model
AccountandAccountServiceas Spezi Module♻️ Current situation & Problem
The
Accountmodel andAccountServices were introduced before Spezi had sophisticated support for Modules. Therefore, SpeziAccount provides infrastructure like the@AccountReferenceto access theAccountmodel from certain places like an Account Service or from a Standard that conforms to a SpeziAccount constraint. Other than that, theAccountmodel can only be accessed from within the SwiftUI view hierarchy.This design is generally relatively inflexible and one has to find workarounds to (a) access
Accountfrom a Spezi Module and (b) access Spezi Modules from within anAccountService. Typically this involves nesting Account Services into basically empty Spezi Modules or injecting ViewModifiers into the global SwiftUI view hierarchy to get access to theAccount.This PR addresses the problem by making
AccountandAccountServicesSpezi Modules that can be used with all Spezi infrastructure like the@Dependencyproperty wrapper. This greatly improves flexibility when developing with SpeziAccount.⚙️ Release Notes
@Dependencyproperty wrapper.AccountServices are now Spezi Modules that can use Spezi infrastructure.📚 Documentation
TBA
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: