Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external ownership for Modules #106

Merged
merged 8 commits into from
Jun 26, 2024

Make sure it works for both compiler versions

1855025
Select commit
Loading
Failed to load commit list.
Merged

Allow external ownership for Modules #106

Make sure it works for both compiler versions
1855025
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 26, 2024 in 0s

87.64% (-0.28%) compared to 734f90c

View this Pull Request on Codecov

87.64% (-0.28%) compared to 734f90c

Details

Codecov Report

Attention: Patch coverage is 86.57718% with 40 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (734f90c) to head (1855025).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   87.93%   87.64%   -0.28%     
==========================================
  Files          42       46       +4     
  Lines        1217     1375     +158     
==========================================
+ Hits         1070     1205     +135     
- Misses        147      170      +23     
Files Coverage Δ
...ilities/Communication/CollectPropertyWrapper.swift 100.00% <100.00%> (ø)
...bilities/Communication/CollectedModuleValues.swift 100.00% <100.00%> (+18.52%) ⬆️
...ilities/Communication/ProvidePropertyWrapper.swift 100.00% <100.00%> (ø)
...ifications/RegisterRemoteNotificationsAction.swift 85.11% <ø> (ø)
...ications/UnregisterRemoteNotificationsAction.swift 100.00% <ø> (ø)
...apabilities/Observable/EnvironmentAccessible.swift 100.00% <100.00%> (ø)
...Capabilities/Observable/ModelPropertyWrapper.swift 66.67% <100.00%> (+8.61%) ⬆️
...ies/ViewModifier/ModelModifierInitialization.swift 100.00% <100.00%> (ø)
...ilities/ViewModifier/ModifierPropertyWrapper.swift 77.78% <100.00%> (+6.35%) ⬆️
...apabilities/ViewModifier/WrappedViewModifier.swift 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734f90c...1855025. Read the comment docs.