-
-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix visibility of NotificationHandler default implementations and mak…
…e Delegate methods open (#102) # Fix visibility of NotificationHandler default implementations and make Delegate methods open ## ♻️ Current situation & Problem The `NotificationHandler` provides empty default implementations but their implementation are not marked public. Therefore, they have no effect. Secondly, some `SpeziAppDelegate` methods are not declared as open. This reduces flexibility in certain cases where it might be helpful to inject custom logic or even just to debug some issues. ## ⚙️ Release Notes * Fixed default implementation of the NotificationHandler. * Make all `SpeziAppDelegate` methods open. ## 📚 Documentation -- ## ✅ Testing -- ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
- Loading branch information
Showing
2 changed files
with
13 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters