Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading state feedback for LLM responses #59

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

jdisho
Copy link
Collaborator

@jdisho jdisho commented Jan 24, 2025

Improve loading state feedback for LLM responses

♻️ Current situation & Problem

Resolving #55

⚙️ Release Notes

  • Instead of a spinner, the chat shows a bubble animation that animates right where the response will appear, making it clear where to look for the incoming responses.
  • The chat also allows users to close the chat view during this time, canceling any requests that are in progress.
Screenshot 2025-01-24 at 11 08 25

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 43.87%. Comparing base (59b59ef) to head (c52ac65).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../MultipleResources/MultipleResourcesChatView.swift 0.00% 32 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   40.44%   43.87%   +3.43%     
==========================================
  Files          31       31              
  Lines        1422     1418       -4     
==========================================
+ Hits          575      622      +47     
+ Misses        847      796      -51     
Files with missing lines Coverage Δ
.../MultipleResources/MultipleResourcesChatView.swift 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b59ef...c52ac65. Read the comment docs.

@jdisho jdisho self-assigned this Jan 24, 2025
@jdisho jdisho requested a review from PSchmiedmayer January 25, 2025 17:23
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you! 🚀

@jdisho jdisho merged commit 33d2dca into main Jan 27, 2025
7 of 8 checks passed
@jdisho jdisho deleted the feat/improve-llm-loading-feedback branch January 27, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants