-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use SpeziLLM, SpeziChat, and Spezi 1.x #36
Conversation
Nice; thank you for looking into this @vishnuravi! 🚀 |
Was waiting for the bugfix in StanfordSpezi/SpeziLLM#50 to get merged and released to finish this. Should be able to finish now. |
Very nice; thanks for all the work here @vishnuravi 🚀 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 87.52% 92.91% +5.40%
==========================================
Files 25 24 -1
Lines 785 832 +47
==========================================
+ Hits 687 773 +86
+ Misses 98 59 -39
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vishnuravi for the update to SpeziLLM, greatly appreciated!
Only had some minor comments and improvement suggestions, no need for a second round of review
Refactor to use SpeziLLM, SpeziChat, and Spezi 1.x
♻️ Current situation & Problem
The current application uses
SpeziML
, which has now been replaced by SpeziLLM. SpeziLLM provides significant additional functionality and will simplify the code. It also uses a pre-release version of Spezi, and should be migrated to the latest production release.⚙️ Release Notes
SettingsView
has been recreated, adhering to Apple Design Guidelines and including additional options to switch the OpenAI model used and change the Open AI API key.📚 Documentation
In-line documentation has been updated.
✅ Testing
SettingsView
and theHealthGPTView
.--mockMode
feature flag to allow for UI testing with mock LLM responses.Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: