Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify measurement recorded sheet behavior with multiple stored measurements. #79

Open
1 task done
nriedman opened this issue Aug 29, 2024 · 0 comments
Open
1 task done

Modify measurement recorded sheet behavior with multiple stored measurements. #79

nriedman opened this issue Aug 29, 2024 · 0 comments
Assignees
@Supereg
Labels
enhancement New feature or request

Comments

@nriedman
Copy link
Contributor

Problem

Currently, when there are multiple past measurements saved on the device, the Measurement Recorded sheet is still dismissed when the user saves one. That means that if a user wants to save multiple past measurements, they need to open the sheet again and again (once per measurement).

Solution

Instead of dismissing the sheet on save, mimic the behavior of the sheet when the user discards the measurement. That is, save the measurement, and once it is saved remove the measurement from the list and move to the next measurement in the queue.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@nriedman nriedman added the enhancement New feature or request label Aug 29, 2024
@Supereg Supereg mentioned this issue Sep 1, 2024
Merged
1 task
Supereg added a commit to StanfordSpezi/SpeziDevices that referenced this issue Sep 2, 2024
@Supereg
Only dismiss the measurements sheet when we are saving the last one (#12
dc8dcd5 
)

# Only dismiss the measurements sheet when we are saving the last one

## ♻️ Current situation & Problem
This PR address StanfordBDHG/ENGAGE-HF-iOS#79
by only dismissing the recorded measurements sheet only if there aren't
any more measurements displayed. This makes it easier for users to save
multiple measurements.

## ⚙️ Release Notes 
* Only dismiss the measurements sheet if the last measurement is saved.
*  Show the last measurement in the closing animation.

## 📚 Documentation
--


## ✅ Testing
Existing test validate this behavior.

## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Supereg Supereg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Supereg @nriedman