-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom providerName for Patients #105
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
========================================
- Coverage 0.89% 0.88% -0.01%
========================================
Files 75 76 +1
Lines 3711 3793 +82
Branches 84 85 +1
========================================
Hits 33 33
- Misses 3607 3688 +81
- Partials 71 72 +1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @arkadiuszbachorski.
Only thing missing is the fact that the Docker compose build seems to fail.
@pauljohanneskraft let's merge this once we have published the latest version of the models package, probably also including the disabled flag.
@PSchmiedmayer it is going to fail, because types are incorrect. I used latest version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - except for one small non-blocking question.
Sounds great! |
55ebf0c
to
0b59b79
Compare
Support custom providerName for Patients
♻️ Current situation & Problem
Closes #103
⚙️ Release Notes
✅ Testing
Tested manually
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: