Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom providerName for Patients #105

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

arkadiuszbachorski
Copy link
Collaborator

@arkadiuszbachorski arkadiuszbachorski commented Jan 16, 2025

Support custom providerName for Patients

♻️ Current situation & Problem

Closes #103

⚙️ Release Notes

  • Support custom providerName for Patients

✅ Testing

Tested manually

⚠️ Do not merge this until models are updated to the latest version.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 0.88%. Comparing base (5f72377) to head (0b59b79).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
routes/~_dashboard/~patients/PatientForm.tsx 0.00% 15 Missing ⚠️
routes/~_dashboard/patients/$id/~index.tsx 0.00% 1 Missing ⚠️
routes/~_dashboard/~patients/~invite.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #105      +/-   ##
========================================
- Coverage   0.89%   0.88%   -0.01%     
========================================
  Files         75      76       +1     
  Lines       3711    3793      +82     
  Branches      84      85       +1     
========================================
  Hits          33      33              
- Misses      3607    3688      +81     
- Partials      71      72       +1     
Files with missing lines Coverage Δ
routes/~_dashboard/patients/$id/~index.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/~patients/~invite.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/~patients/PatientForm.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1c16b...0b59b79. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @arkadiuszbachorski.
Only thing missing is the fact that the Docker compose build seems to fail.

@pauljohanneskraft let's merge this once we have published the latest version of the models package, probably also including the disabled flag.

@arkadiuszbachorski
Copy link
Collaborator Author

arkadiuszbachorski commented Jan 19, 2025

Only thing missing is the fact that the Docker compose build seems to fail.

@PSchmiedmayer it is going to fail, because types are incorrect. I used latest version of models package locally and this PR tries to rely on models which do not have providerName. It's going to be resolved once all the firebase PRs are merged and new models version is published.

Copy link
Contributor

@pauljohanneskraft pauljohanneskraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - except for one small non-blocking question.

routes/~_dashboard/~patients/PatientForm.tsx Outdated Show resolved Hide resolved
@PSchmiedmayer
Copy link
Member

Sounds great!
Thank you @arkadiuszbachorski & @pauljohanneskraft for merging all the changes in the Firebase repo and merging this PR, as far as I can see we can tag a 0.6.0 release in the Firebase repo 👍

@arkadiuszbachorski arkadiuszbachorski force-pushed the arek/support-custom-provider-name branch from 55ebf0c to 0b59b79 Compare January 20, 2025 11:15
@arkadiuszbachorski arkadiuszbachorski merged commit 59dfc71 into main Jan 20, 2025
10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/support-custom-provider-name branch January 20, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a text box field for name of doctor to patient enrollment
3 participants