Skip to content

Commit

Permalink
recreate PR 22 - migration observability to be compliant with vue3
Browse files Browse the repository at this point in the history
  • Loading branch information
aalves08 authored and owanturist committed Nov 6, 2024
1 parent 1dbe33f commit 3f815b9
Show file tree
Hide file tree
Showing 6 changed files with 3,973 additions and 7,057 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ module.exports = {
'standard',
'eslint:recommended',
'@nuxtjs/eslint-config-typescript',
'plugin:cypress/recommended'
],
// add your custom rules here
rules: {
Expand All @@ -31,6 +30,7 @@ module.exports = {
'vue/html-self-closing': 'off',
'vue/no-unused-components': 'warn',
'vue/no-v-html': 'error',
'vue/no-v-model-argument': 'off',
'wrap-iife': 'off',

'array-bracket-spacing': 'warn',
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
12 changes: 5 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,18 @@
"license": "Apache-2.0",
"private": true,
"engines": {
"node": ">=12"
"node": ">=20"
},
"workspaces": [
"pkg/*"
],
"dependencies": {
"@rancher/components": "0.2.1-alpha.0",
"@rancher/shell": "^2.0.1",
"@types/lodash": "4.14.184",
"core-js": "3.21.1"
"@rancher/shell": "^3.0.0-rc.9"
},
"resolutions": {
"**/webpack": "4",
"@types/node": "^16"
"devDependencies": {
"@nuxtjs/eslint-config-typescript": "6.0.1",
"@types/lodash": "4.14.184"
},
"scripts": {
"lint": "eslint --ext .ts,.js,.vue",
Expand Down
11 changes: 5 additions & 6 deletions pkg/observability/components/Dashboard/ConfigurationView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export default {
this.urlError = false;
}
},
},
computed: {
isCreateMode() {
Expand Down Expand Up @@ -146,7 +145,7 @@ export default {
<div class="banner-info">
<p>{{ t("observability.dashboard.connected") }}</p>
<!-- reserve a line when the url is an empty string so UI won't jump on change -->
<a :href="`https://${suseObservabilityURL}/`">{{ suseObservabilityURL || '&nbsp;' }}</a>
<a :href="`https://${suseObservabilityURL}/`">{{ suseObservabilityURL || "&nbsp;" }}</a>
</div>
</Banner>
Expand All @@ -170,22 +169,22 @@ export default {
class="configuration-inputs"
>
<LabeledInput
v-model="suseObservabilityURL"
v-model:value="suseObservabilityURL"
:label="t('observability.configuration.url')"
class="url-input"
:class="{'error': urlError }"
:class="{ error: urlError }"
required
/>
<div class="pt-10 pb-10">
<p
v-show="urlError"
class="url-error mb-10"
>
{{ t('observability.configuration.urlError') }}
{{ t("observability.configuration.urlError") }}
</p>
</div>
<LabeledInput
v-model="suseObservabilityServiceToken"
v-model:value="suseObservabilityServiceToken"
class="mb-20"
type="password"
:label="t('observability.configuration.serviceToken')"
Expand Down
12 changes: 6 additions & 6 deletions pkg/observability/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"rancher": {
"annotations": {
"catalog.cattle.io/kube-version": ">= 1.16.0-0",
"catalog.cattle.io/rancher-version": ">= 2.9.0 < 2.10.0",
"catalog.cattle.io/ui-extensions-version": ">= 2.0.1"
"catalog.cattle.io/rancher-version": ">= 2.10.0",
"catalog.cattle.io/ui-extensions-version": ">= 3.0.0"
}
},
"icon": "https://raw.githubusercontent.com/stackvista/rancher-extension-stackstate/main/pkg/observability/rancher-observability.svg",
Expand All @@ -18,12 +18,12 @@
"nuxt": "./node_modules/.bin/nuxt"
},
"engines": {
"node": ">=12"
"node": ">=20.0.0"
},
"devDependencies": {
"@vue/cli-plugin-babel": "4.5.18",
"@vue/cli-plugin-typescript": "4.5.18",
"@vue/cli-service": "4.5.18"
"@vue/cli-plugin-babel": "~5.0.0",
"@vue/cli-plugin-typescript": "~5.0.0",
"@vue/cli-service": "~5.0.0"
},
"browserslist": [
"> 1%",
Expand Down
Loading

0 comments on commit 3f815b9

Please sign in to comment.