Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tests review #120

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

New tests review #120

wants to merge 11 commits into from

Conversation

annekauf
Copy link
Collaborator

New tests, one failing on live system and green on Ranking1, one failing both.

(Omitting Author's last name in the search terms searching AllFields would yield desired result: reviews AFTER reviewed book)

Added bq-functions discriminating Review/Rezension in searchspecs.yaml (several in AllFields, one in Title).

added test "Bach und die drei Temporätsel" to reviews.cy.js.

Test should be green as in live system
cranking up discrimination values of reviews
mäser bach und die drei temporätsel
added test (allfields Mäser Bach und die drei Temporätsel) and refined test (title Bach und die drei Temporätsel)
#23
#12
added lines to discriminate Reviews/Rezensionen
#12
#23
one green, one passed
@annekauf annekauf closed this Dec 3, 2024
@annekauf annekauf reopened this Dec 3, 2024
@annekauf
Copy link
Collaborator Author

annekauf commented Dec 3, 2024

yaml has been fixed, thanks! PR could now be merged? Or is the fix-commit not on this PR, although in branch? Test results "review" as expected (see above).
Tests overall: major regression in author and chronology one more failed test in duplicates:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant