Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed recipe #4156

Closed
wants to merge 0 commits into from
Closed

Conversation

mosemister
Copy link
Member

@mosemister mosemister commented Jan 3, 2025

API | Impl

  • Fixes reciving recipes from the RecipeManager
  • implements the ability to get the recipe key

Original Issue:

Calling the following code would cause a ClassCastException caused by Recipe not being able to be cast to RecipeHolder.

Sponge.server().recipeManager().all();

The issue is that in MC 1.21.1, recipes added a wrapper that holds the recipe and the associated key in RecipeHolder and the internal RecipeManager now outputs those RecipeHolder rather then Recipe.

@mosemister
Copy link
Member Author

Changing implementation to make it so it applies the key using ResourceHolder#value instead of in the manager

Also disabling my auto formatter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant