Fix aggregate_channels merging of channel ids with different string sub type
#3740
+35
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error comes from the token limit : P |
chrishalcrow
reviewed
Mar 5, 2025
| chan_id in parents_chan_ids for chan_id in self._channel_ids | ||
| ), "ChannelSliceRecording : channel ids are not all in parents" | ||
| is_channel_in_parent = [chan_id in parents_chan_ids.tolist() for chan_id in self._channel_ids.tolist()] | ||
| assert all(is_channel_in_parent), "ChannelSliceRecording : channel ids are not all in parents" |
There was a problem hiding this comment.
Could be helpful to list them? Something like
channels_not_in_parents = [chan_id for chan_id in self._challen_ids.tolist() if chan_id not in parents_chan_ids.tolist()]
assert len(channels_not_in_parents) == 0, f"ChannelSliceRecording : channel ids {channels_not_in_parents} are not all in parent ids {parents_chan_ids}"
Or maybe this is totally overwhelming for large dense probes?
There was a problem hiding this comment.
I think it would be good to add the channel list in the error message
There was a problem hiding this comment.
Good idea. I will add in the next commit.
chrishalcrow
reviewed
Mar 5, 2025
| @@ -118,5 +118,19 @@ def test_channel_aggregation_does_not_preserve_ids_not_the_same_type(): | |||
| assert list(aggregated_recording.get_channel_ids()) == ["0", "1", "2", "3", "4"] | |||
|
|
|||
|
|
|||
| def test_channel_aggregation_with_string_dtypes_of_different_size(): | |||
There was a problem hiding this comment.
Lovely test!
Would be nice to have a docstring with a brief description.
There was a problem hiding this comment.
Added a docstring. Let me know what you think.
|
Works for me, and looks less hacky than my proposed solution. Just made some doc-y comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix @chrishalcrow bug on #3733.
The current check for
all_channels_have_same_typeis too strict. I added a test.