Add warning message for streams with mixed units #3739
+23
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing PR #3728, I don't think we should be raising a warning when non-voltage units are found. Loading data with NIDQ or other non-neural recordings should be fine. For that case, the current warning isn't useful and I think is just noise.
What we should warn the user about is when the extractor contains mixed units (voltage and non-voltage), as this likely indicates that the stream should be subsetted and it will not work directly for most routines here. This PR improves this and gives the user the tools to figure out which channels might have to be removed.
As a side benefit, this also addresses a request that @samuelgarcia made a while ago (I think two years) to move this warning logic from the base extractor to Neo which I agreed but never had the time to do.