-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runs an intergation test in linux, windows and macos #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2024
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose here is to have github actions run an actual job using spalloc proxy.
The c build action has been changed
Then a new job has been added which runs an actual job on an actual machine
The first integration test is a very simple graph but in debug nodes so all reporting is tried.
Note the spynnaker_neuron_graph_network_specification_report will raise a caught exception in Windows and macos as installing the graphviz on these platforms was considered out of scope for a rarely used report.
These Support script/ yml files are a key part of this work but had to go into main to work.
Single workflow to run all python tests. With flags for the difference between repositories
https://github.com/SpiNNakerManchester/SupportScripts/blob/main/.github/workflows/python_checks.yml
A shared action for all the preparation setup work.
https://github.com/SpiNNakerManchester/SupportScripts/tree/main/actions/prepare
Install the Linux package or skip if not in linux
https://github.com/SpiNNakerManchester/SupportScripts/blob/main/actions/apt-get-install/action.yml
Depends on/ includes:
SpiNNakerManchester/SpiNNUtils#272
SpiNNakerManchester/SpiNNMachine#264
SpiNNakerManchester/SpiNNMan#405
SpiNNakerManchester/PACMAN#564
SpiNNakerManchester/SpiNNFrontEndCommon#1192
SpiNNakerManchester/MarkovChainMonteCarlo#67
Will need branch protection rules changing either before or after the pr.