Skip to content

Commit

Permalink
make sure full mypy run in all python versions
Browse files Browse the repository at this point in the history
  • Loading branch information
Christian-B committed Oct 18, 2024
1 parent 042da46 commit 72f53ae
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/workflows/python_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,14 @@ on:
These are run in --disallow-untyped-defs mode
required: false
type: string
default: ''
mypy-packages:
description: >
The names of Python packages to run simple mypy on.
These are run in without --disallow-untyped-defs
required: false
type: string
default: ''
rat_config_file:
description: >
Which xml config file to use for rat.
Expand Down Expand Up @@ -187,6 +189,7 @@ jobs:
language: en_GB

- name: Lint with mypy
if: ${{ inputs.mypy-packages != ''}}
run: mypy --python-version ${{ matrix.python-version }} ${{ inputs.mypy-packages }}

- name: Lint with mypy using disallow-untyped-def
Expand Down Expand Up @@ -259,7 +262,11 @@ jobs:

- name: Lint with mypy
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true') && inputs.mypy-packages != '' }}
run: mypy ${{ inputs.mypy-packages }}
run: mypy --python-version ${{ matrix.python-version }} ${{ inputs.mypy-packages }}

- name: Lint with mypy using disallow-untyped-def
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true') && inputs.mypy-full-packages != '' }}
run: mypy --python-version ${{ matrix.python-version }} --disallow-untyped-defs ${{ inputs.mypy-full-packages }}

- name: Test with pytest
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true') && inputs.test_directories != ''}}
Expand Down

0 comments on commit 72f53ae

Please sign in to comment.