Handle bmp errors #1101
Merged
Handle bmp errors #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89fd0fe.
|
Tests here are mostly passing (against the demo server with the changes above): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that BMP errors do not result in success! Also ensures that BMPs are not powered on until at least 30 seconds after they have been powered off. This does not affect allocations; the boards will be allocated but will wait off until the 30 seconds have passed. This won't affect most users, just those who ask for specific boards (normal users will likely be allocated other boards anyway).
Also adds some features to the UI (power on/off machine and show real user on compatibility jobs).