Added catched for the NullReferenceException we keep encountering wit…

…h browser extensions that should give us more information to work off of. Also removed an old debug catch that I forgot to take out in the last commit.
Spec-ify · May 28, 2024 · c997437 · c997437
1 parent c069a1c
commit c997437
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/client/data/Methods/System.cs b/client/data/Methods/System.cs
@@ -695,6 +695,10 @@ await LogEventAsync($"Exception occured in GetBrowserExtension() during Firefox
                                 if (e is FileNotFoundException || e is JsonException)
                                     await LogEventAsync($"Error reading manifest or locale data for {di.Name} in {browser.Name}",
                                         Region.System, EventType.WARNING);
+
+                                if (e is NullReferenceException)
+                                    await LogEventAsync($"Null reference caught reading {di.Name} in {browser.Name}",
+                                        Region.System, EventType.WARNING);
                             }
                         }
                     }
@@ -731,8 +735,9 @@ await LogEventAsync($"Exception occured in GetBrowserExtension() during Firefox
                                     await LogEventAsync($"Error reading manifest or locale data for {di.Name} in {browser.Name}",
                                         Region.System, EventType.WARNING);
 
-                                if (e is ArgumentOutOfRangeException)
-                                    Console.WriteLine("I am here!");
+                                if (e is NullReferenceException)
+                                    await LogEventAsync($"Null reference caught reading {di.Name} in {browser.Name}",
+                                        Region.System, EventType.WARNING);
                             }
                     }
                 }

diff --git a/client/data/Utils.cs b/client/data/Utils.cs
@@ -190,6 +190,11 @@ public static Browser.Extension ParseChromiumExtension(string path)
             DebugLog.LogEvent($"Chromium extension path invalid: {path}", DebugLog.Region.System, DebugLog.EventType.WARNING);
             return null;
         }
+        catch (NullReferenceException e)
+        {
+            DebugLog.LogEvent($"Null reference caught reading extension data at {path}", DebugLog.Region.System, DebugLog.EventType.WARNING);
+            return null;
+        }
         catch (Exception e)
         {
             DebugLog.LogEvent($"Unexpected exception occured in ParseChromiumExtension: {e}", DebugLog.Region.System, DebugLog.EventType.ERROR);