Skip to content

Commit

Permalink
Remove assertion for dialect+driver
Browse files Browse the repository at this point in the history
  • Loading branch information
SpaceCondor committed Oct 11, 2024
1 parent 4b811a8 commit 5178621
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions target_postgres/target.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,9 @@ def __init__(
and self.config.get("port") is not None
and self.config.get("user") is not None
and self.config.get("password") is not None
and self.config.get("dialect+driver") is not None
), (
"Need either the sqlalchemy_url to be set or host, port, user,"
+ "password, and dialect+driver to be set"
"Need either the sqlalchemy_url to be set or host, port, user, "
+ "and password to be set"
)

# If sqlalchemy_url is not being used and ssl_enable is on, ssl_mode must have
Expand Down
2 changes: 1 addition & 1 deletion target_postgres/tests/test_target_postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def test_port_config():
"database": "postgres",
"port": 5433,
}
dialect_driver = config["dialect+driver"]
dialect_driver = "postgresql+psycopg"
host = config["host"]
user = config["user"]
password = config["password"]
Expand Down

0 comments on commit 5178621

Please sign in to comment.