DIA-4059 refactor android interface #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| concreteInstance = Application.platform switch | ||
| { | ||
| RuntimePlatform.Android => new ConsentWrapperAndroid(), | ||
| RuntimePlatform.IPhonePlayer => new ConsentWrapperAndroid(), |
There was a problem hiding this comment.
RuntimePlatform.IPhonePlayer => new ConsentWrapperAndroid()
@Nevazhnovu is this line correct?
There was a problem hiding this comment.
@andresilveirah you are right, that's a typo. My bad!
| public string webConsentPayload; | ||
| public ConsentStatusWrapper consentStatus; | ||
| #nullable enable | ||
| public GCMDataWrapper? gcmStatus; | ||
| #nullable disable | ||
| } |
There was a problem hiding this comment.
@Nevazhnovu were applies an gcmStatus removed on purpose?
There was a problem hiding this comment.
@andresilveirah Yup, that's done purposefully. The applies and gcmStatus have moved to SpGdprConsentWrapper<platform>.cs classes
…actor-android-interface * DIA-4057-refactor-cmp-class-abstract: Update `CHANGELOG.md` Update `unitypackage` Update `package.json` Update native Android SDK to `7.8.4` Fix unwrapping `applies` for Android # Conflicts: # Assets/ConsentManagementProvider/Scripts/json/JsonUnwrapper.cs # Assets/ConsentManagementProvider/Scripts/json/wrappers/android/SpGdprConsentWrapperAndroid.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.