Miscellaneous changes #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vauff
commented
Dec 25, 2023
Vauff
commented
- Fixed extend time being applied twice
- Fixed extend votes being able to be rapidly chained when more than one is available
- Allowed Discord webhooks to not override default settings
- Added player IP tracking
- Deduplicated JSON parsing code
- Switched to safer method of string storage in HTTPHeader & TrackedRequest classes
- Added missing header files to VS project files
- Added missing map vote cvars to cs2fixes.cfg
- Made config file formatting consistent
- Some code cleanup in c_http debug command
- Fixed memdbgon.h not being last include in events.cpp
- Fixed !setnextmap not having correct admin flag
- Switched to simpler CON_COMMAND_CHAT macro for most map vote commands
- Fixed extend time being applied twice - Fixed extend votes being able to be rapidly chained when more than one is available
Discord webhooks already have a default avatar/name, sending them in the request only overrides them. This allows the original values to be used.
- Deduplicated JSON parsing code - Switched to safer method of string storage in HTTPHeader & TrackedRequest classes
- Added missing header files to VS project files - Added missing map vote cvars to cs2fixes.cfg - Made config file formatting consistent - Some code cleanup in c_http debug command - Fixed memdbgon.h not being last include in events.cpp - Fixed !setnextmap not having correct admin flag - Switched to simpler CON_COMMAND_CHAT macro for most map vote commands
xen-000
approved these changes
Dec 26, 2023
GXTX
reviewed
Dec 27, 2023
| // Remove port | ||
| for (int i = 0; i < ip.length(); i++) | ||
| { | ||
| if (ip[i] == ':') |
There was a problem hiding this comment.
Consider using ip.find_last_of(':') instead, this will break if IPv6 in the future.
GXTX
reviewed
Dec 27, 2023
| @@ -129,7 +129,7 @@ void CPlayerManager::OnBotConnected(CPlayerSlot slot) | |||
| m_vecPlayers[slot.Get()] = new ZEPlayer(slot, true); | |||
| } | |||
|
|
|||
| bool CPlayerManager::OnClientConnected(CPlayerSlot slot, uint64 xuid) | |||
| bool CPlayerManager::OnClientConnected(CPlayerSlot slot, uint64 xuid, const char* pszNetworkID) | |||
GXTX
reviewed
Dec 27, 2023
| @@ -127,6 +129,7 @@ class ZEPlayer | |||
| float m_flExtendVoteTime; | |||
| int m_iFloodTokens; | |||
| float m_flLastTalkTime; | |||
| std::string m_strIp; | |||
There was a problem hiding this comment.
Consider default initializing member variables in the future
GXTX
reviewed
Dec 27, 2023
| // Allow another extend vote after 2 minutes | ||
| new CTimer(120.0f, false, []() | ||
| // Allow another extend vote after added time lapses | ||
| new CTimer(g_iExtendTimeToAdd * 60.0f, false, []() |
There was a problem hiding this comment.
C++std is set to C++ 20, should be using smart pointers... Same with the delete here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.