[SONARPHP-1024] Do not save metrics for test files.

sonar-php-plugin/src/main/java/org/sonar/plugins/php/PHPSensor.java

@@ -185,10 +185,10 @@ void scanFile(InputFile inputFile) {
         if (!inSonarLint(context)) {
           phpAnalyzer.getSyntaxHighlighting(context, inputFile).save();
           phpAnalyzer.getSymbolHighlighting(context, inputFile).save();
-          saveNewFileMeasures(context,
-            phpAnalyzer.computeMeasures(fileLinesContextFactory.createFor(inputFile)),
-            inputFile);
           if (inputFile.type() == Type.MAIN) {
+            saveNewFileMeasures(context,
+              phpAnalyzer.computeMeasures(fileLinesContextFactory.createFor(inputFile)),
+              inputFile);
             saveCpdData(phpAnalyzer.computeCpdTokens(), inputFile, context);
           }
         }

sonar-php-plugin/src/test/java/org/sonar/plugins/php/PHPSensorTest.java

@@ -98,6 +98,7 @@ public class PHPSensorTest {
 
   private static final String PARSE_ERROR_FILE = "parseError.php";
   private static final String ANALYZED_FILE = "PHPSquidSensor.php";
+  private static final String TEST_FILE = "Test.php";
 
   private Set<File> tempReportFiles = new HashSet<>();
 
@@ -449,6 +450,26 @@ public void should_disable_unnecessary_features_for_sonarlint() throws Exception
     assertThat(context.referencesForSymbolAt(mainFileKey, 6, 7)).isNotNull();
   }
 
+  @Test
+  public void no_measures_for_test_files() {
+    checkFactory = new CheckFactory(new ActiveRulesBuilder()
+      .addRule(newActiveRule("S2187"))
+      .build());
+
+    InputFile testFile = inputFile(TEST_FILE, Type.TEST);
+
+    String testFileKey = testFile.key();
+
+    context.fileSystem().add(testFile);
+    context.setRuntime(NOT_SONARLINT_RUNTIME);
+
+    createSensor().execute(context);
+
+    assertThat(context.allIssues()).isNotEmpty();
+    assertThat(context.measure(testFileKey, CoreMetrics.NCLOC)).isNull();
+
+  }
+
   @Test
   public void should_use_multi_path_coverage() throws Exception {
     context.setRuntime(SONARQUBE_6_7);

sonar-php-plugin/src/test/resources/Test.php

@@ -0,0 +1,5 @@
+<?php
+
+use PHPUnit\Framework\TestCase;
+
+class MyTest extends TestCase {}