SONARJAVA-4446 Check if the parent class or implemented interface symbols of the test class are known. #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
erwan-serandour
force-pushed
the
erwan/S2187_SONARJAVA-4446
branch
from
ce3965a to
1d1b1c7
Compare
| @@ -21,6 +21,18 @@ | |||
| import com.googlecode.zohhak.api.TestWith; | |||
| import com.googlecode.zohhak.api.runners.ZohhakRunner; | |||
|
|
|||
| class SubclassTest extends ParentTestClass { // Compliant, we cannot know what is in ParentTestClass so we don't raise issues | |||
There was a problem hiding this comment.
Could we change the name so it suggests that the class is not defined, for example, UndefinedParentTestClass?
| } | ||
|
|
||
| abstract class ResolvedParent {} | ||
| class Subclass4Test extends ResolvedParent {} // Noncompliant |
There was a problem hiding this comment.
I don't see a good reason to put this new block at the beginning of the file. Could we move it towards the end?
| @@ -78,7 +79,16 @@ private void resetAnnotationCache() { | |||
| } | |||
|
|
|||
| private void checkClass(ClassTree classTree) { | |||
| if (!ModifiersUtils.hasModifier(classTree.modifiers(), Modifier.ABSTRACT)) { | |||
| boolean knownParent = Optional.ofNullable(classTree.superClass()) | |||
There was a problem hiding this comment.
I think a more typical way of doing this would be to define private static knownParent(...) and use if in if-then. Same for knownImplementedInterfaces. You could even put this new check into one method.
|
tomasz-tylenda-sonarsource
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-4446
If any symbol is not known, do not raise an issue to avoid false positives.