NET-936 Modify S3247: Add benchmarks #4596
Conversation
sebastien-marichal
changed the title
rules/S3247/csharp/rule.adoc
Outdated
|
|
||
| [options="header"] | ||
| |=== | ||
| | Method | Runtime | Mean | Standard Deviation | Ratio |
There was a problem hiding this comment.
We don't always include the Ratio column.
I guess it make sense with the Benchmark category.
However, if we decide to keep it, I am wondering what would be the result in the UI.
There was a problem hiding this comment.
I think we should not include the Ratio column.
I talked with Greg that spend some time on what to show in Benchmarks and said the Ratio was misleading.
rules/S3247/csharp/rule.adoc
Outdated
| | IsPattern_ValueType | .NET 9.0 | 22.58 ns | 1.161 ns | 1.00 | ||
| | IsWithCast_ValueType | .NET 9.0 | 19.41 ns | 2.675 ns | 0.86 |
There was a problem hiding this comment.
I hope that it will not bring more work for us and that this point:
* Performance: Performing the type check and cast separately can lead to minor performance issues. While this might not be noticeable in small applications, it can add up in larger, more complex systems.
will be enough for users to not be too picky about this rule being tagged as performance.
|
|
Review
A dedicated reviewer checked the rule description successfully for: