Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S3330: Add Go language #2770

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Modify rule S3330: Add Go language #2770

merged 6 commits into from
Jan 24, 2025

Conversation

sebastien-andrivet-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource changed the title Modify rule S2092: Add Go language Modify rule S3330: Add Go language Aug 3, 2023
egon-okerman-sonarsource
egon-okerman-sonarsource approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the small formatting issue

rules/S3330/go/rule.adoc Outdated Show resolved Hide resolved
@sonarqube-next
Copy link

sonarqube-next bot commented Aug 4, 2023

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

sonarqube-next bot commented Aug 4, 2023

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@necto necto added the go label Aug 21, 2023
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mstachniuk mstachniuk merged commit 9a672e7 into master Jan 24, 2025
8 of 9 checks passed
@mstachniuk mstachniuk deleted the andrivet/S3330 branch January 24, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egon-okerman-sonarsource egon-okerman-sonarsource egon-okerman-sonarsource approved these changes

Assignees
No one assigned
Labels
go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastien-andrivet-sonarsource @egon-okerman-sonarsource @mstachniuk @necto