Improve error message on non Win #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My assumption is that there are not a lot of complaints about the undefined behavior (or any other issues) due to the lack of users. It's not a popular module. However, I will review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only supposed to be run on Win, but it can end up on other platforms. Also the error message can be confusing for some users, as shown in [SO]: I can't use WConio2 on python.
There was another package with the same problem, I submitted [GitHub]: Prevent .whl installation (OOTB) on non Win, but it wasn't OK. I then submitted another PR where I inspired this one from.
Note: I also mentioned WConio2 in [SO]: Install win32com on MacOs and Linux (@CristiFati's answer).
On another (completely unrelated) topic, this module is full of Undefined Behaviors, and I wonder how come there aren't lots of bug reports. Check [SO]: C function called from Python via ctypes returns incorrect value (@CristiFati's answer) for more details.