Make State pub(crate).
#42
Conversation
andriyDev
force-pushed
the
private-state
branch
from
e921d34 to
a6d7653
Compare
|
Fixed rebase conflicts. Unfortunately it looks like there's a new lint or something because this PR is failing due to State suffixes on all the State variants. I'd like to address this in a separate PR (or more likely as part of #41). Therefore I think this PR is fine to move forward with. |
|
Ahhh actually, it looks like the lint by default only applies to enums that aren't public (the logic being that it would be annoying if introducing a lint resulted in a breaking change). I will fix this now then. |
There was a problem hiding this comment.
Looks good, makes sense to remove State! You need to rebase and bump minor version now since changing the API (I don't want to move this crate to major version 1 yet )
ref semantic versioning https://semver.org/
Let me know when comments have been addressed and I'll approve it :)
andriyDev
force-pushed
the
private-state
branch
from
20aa98d to
374420f
Compare
|
I rebased, but I think to handle the version bump we should just merge #38. Otherwise these will both just have the same commit so one will get dropped anyway (I'm gonna have to do a rebase again once either of them is merged anyway). |
Users shouldn't be messing with the internal state of the behavior tree. That could result in the behavior tree producing all sorts of strange behavior.
andriyDev
force-pushed
the
private-state
branch
from
374420f to
81de94f
Compare
|
Sorry for the delay! I didn't notice the approvals. Rebased onto #38. |
Users shouldn't be messing with the internal state of the behavior tree. That could result in the behavior tree producing all sorts of strange behavior.