Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies with SV06 (Plus) ACE profiles, and pull in start G-code fix from Sovol #8035

Closed
wants to merge 3 commits into from

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Jan 14, 2025

Description

A few changes to the stock profiles for the SV06 ACE (recently released) and SV06 Plus ACE (not released yet, AFAICT). These are bug fixes on the stock profiles rather than anything that deviates from how Sovol appears to have intended to set them up:

  • Removed the - official suffix from the profile names. It doesn't seem to be used elsewhere (except for a couple random Comgrow printers), and clutters up the profile list.
  • Removed the retract_minimum_trave setting, which doesn't exist and appears to be a typo for retraction_minimum_travel. Updated retraction_minimum_travel for the SV06 ACE from 2mm to 1mm, which appears to have been Sovol's intent with the typo'd setting. (This also brings that setting's value in line with what the SV06 Plus ACE already has.)
  • Updated the SV06 ACE's start G-code to match the latest recommendation from Sovol, which is to heat the bed before running START_PRINT, which performs the adaptive mesh bed level) (This also brings the SV06 ACE in line with the SV06 Plus ACE, which already did this.)

One thing about the profile I didn't change, but considered: Sovol defaults to a skirt with one loop at distance 0mm. I'm not sure the point of that: it's the world's worst brim, and quite annoying to remove. But that is how they configured it, and so I figured I'd leave that part alone.

Screenshots/Recordings/Graphs

N/A

Tests

Used these modified profiles locally with my SV06 ACE and verified the settings were as expected.

@liberodark
Copy link
Contributor

Hi @bcat

I had already made some changes on my side.
If you are ok I took the liberty of adding your changes directly to my PR too.
#8025

Best Regards

@bcat
Copy link
Contributor Author

bcat commented Jan 14, 2025

Hi @bcat

I had already made some changes on my side. If you are ok I took the liberty of adding your changes directly to my PR too. #8025

Best Regards

Oh certainly, go ahead! I didn't see your PR or else I would have left a comment there. :)

@liberodark
Copy link
Contributor

liberodark commented Jan 14, 2025

Also have see sommes issue in configuration file of sovol :

For example :
This is incorrect for me

"retract_before_wipe": [
     "100",
     "100"
],

I think that is good :

"retract_before_wipe": [
    "100%"
],

@liberodark
Copy link
Contributor

liberodark commented Jan 14, 2025

Hi, @bcat
If you are ok could close your PR because it is integrated into mine this would avoid a conflict.
And I am quoted in the PR.
PS : If you have any changes to make on sovol SV06 ACE tell me in my PR.
I will add it because there are quite a few things to review.

Best Regards

@bcat
Copy link
Contributor Author

bcat commented Jan 15, 2025

Hi, @bcat If you are ok could close your PR because it is integrated into mine this would avoid a conflict. And I am quoted in the PR. PS : If you have any changes to make on sovol SV06 ACE tell me in my PR. I will add it because there are quite a few things to review.

Best Regards

Yup, I'll close this PR then. Thanks for incorporating it into yours!

@bcat bcat closed this Jan 15, 2025
@bcat bcat deleted the sv06-ace branch January 15, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants