fix: add check for payload size

SocketDotTech · Jun 18, 2024 · 8640a08 · 8640a08
1 parent 9f35b33
commit 8640a08
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -133,6 +133,7 @@ It is recommended to setup the ide to work with solidity development. In case of
 | InsufficientFees()          | 0x8d53e553 |
 | InvalidMsgValue()           | 0x1841b4e1 |
 | FeesTooHigh()               | 0xc9034e18 |
+| PayloadTooLarge()           | 0x492f620d |
 | InvalidBatchSize()          | 0x7862e959 |
 | InsufficientMessageLength() | 0xbcfdc01d |
 | InvalidPacketLength()       | 0x5a375a8e |

diff --git a/contracts/ExecutionManager.sol b/contracts/ExecutionManager.sol
@@ -16,6 +16,8 @@ import {FEES_UPDATE_SIG_IDENTIFIER, RELATIVE_NATIVE_TOKEN_PRICE_UPDATE_SIG_IDENT
  * access control.
  */
 contract ExecutionManager is IExecutionManager, AccessControlExtended {
+    uint256 private constant PAYLOAD_LIMIT = 5000;
+
     ISignatureVerifier public immutable signatureVerifier__;
     ISocket public immutable socket__;
     uint32 public immutable chainSlug;
@@ -155,6 +157,8 @@ contract ExecutionManager is IExecutionManager, AccessControlExtended {
 
     error OnlySocket();
 
+    error PayloadTooLarge();
+
     /**
      * @dev Constructor for ExecutionManager contract
      * @param owner_ address of the contract owner
@@ -324,6 +328,7 @@ contract ExecutionManager is IExecutionManager, AccessControlExtended {
         bytes32 executionParams_,
         uint32 siblingChainSlug_
     ) internal view returns (uint128) {
+        if (payloadSize_ > PAYLOAD_LIMIT) revert PayloadTooLarge();
         uint256 totalNativeValue = _calculateExecutionFees(
             msgGasLimit,
             payloadSize_,

diff --git a/test/managers/ExecutionManager.t.sol b/test/managers/ExecutionManager.t.sol
@@ -293,8 +293,8 @@ contract ExecutionManagerTest is Setup {
     }
 
     function testPayAndCheckFeesWithExecutionFeeTooHigh() public {
-        uint256 minMsgGasLimit = 100000;
-        uint256 payloadSize = type(uint128).max;
+        uint256 minMsgGasLimit = type(uint128).max;
+        uint256 payloadSize = 1000;
         uint256 msgValue = 1000;
         uint8 paramType = 1;
         bytes32 executionParams = bytes32(
@@ -321,6 +321,14 @@ contract ExecutionManagerTest is Setup {
             executionParams,
             _b.chainSlug
         );
+
+        vm.expectRevert(ExecutionManager.PayloadTooLarge.selector);
+        _a.executionManager__.getMinFees(
+            minMsgGasLimit,
+            6000,
+            executionParams,
+            _b.chainSlug
+        );
     }
 
     function testPayAndCheckFeesWithMsgValueTooHigh() public {