Arbitrary call from Polkadot to Ethereum contract #924

claravanstaden · 2023-08-08T17:53:52Z

Smoke test to send xcm to template parachain
Template chain forwards message to bridge hub
Bridge hub forwards message to outbound router
Outbound router message transform to Gateway contract
Execute contract in AgentExecute
Figure out how to do the dynamic fees

codecov · 2023-08-08T18:06:11Z

Codecov Report

Patch coverage: 61.05% and project coverage change: -0.44% ⚠️

Comparison is base (d1590d0) 74.42% compared to head (286491d) 73.99%.
Report is 3 commits behind head on main.

❗ Current head 286491d differs from pull request most recent head 43935b6. Consider uploading reports for the commit 43935b6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   74.42%   73.99%   -0.44%     
==========================================
  Files          41       41              
  Lines        1834     1915      +81     
  Branches       74       79       +5     
==========================================
+ Hits         1365     1417      +52     
- Misses        449      475      +26     
- Partials       20       23       +3

Flag	Coverage Δ
rust	`74.58% <71.42%> (-0.19%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
parachain/primitives/core/src/outbound.rs	`15.49% <0.00%> (-1.70%)`	⬇️
contracts/src/Gateway.sol	`70.96% <18.75%> (-2.51%)`	⬇️
contracts/src/AgentExecutor.sol	`73.33% <55.55%> (-26.67%)`	⬇️
parachain/primitives/router/src/outbound/mod.rs	`84.32% <77.58%> (-3.65%)`	⬇️
parachain/pallets/outbound-queue/src/lib.rs	`92.30% <100.00%> (+1.89%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

parachain/primitives/core/src/outbound.rs

contracts/src/AgentExecutor.sol

parachain/primitives/router/src/outbound/mod.rs

claravanstaden · 2023-08-14T18:22:06Z

@yrong I have added a new extrinsic in the template parachain. To use the BridgeXcmSender, I need to add a bunch of config from the pallet-bridge-transfer-primitives crate. I'm not sure including the pallet-bridge-transfer-primitives as a dependency (which, incidentally, seems to have some no-std problem) in the template parachain is the right move? Let me know your thoughts and if this seems on the right track.

yrong · 2023-08-15T02:35:45Z

I'm not sure including the pallet-bridge-transfer-primitives as a dependency (which, incidentally, seems to have some no-std problem) in the template parachain is the right move?

Yes, actually it's not required. But since you've done some integration already so I just did some fix in faccaee based on current implementation.

For the smoke test

cargo test --test transact_polkadot_to_ethereum

Log in bridgehub shows it reach EthereumBlobExporter as expected, so would assume will not block you and we can just continue the unfinished Convert logic based on that.

2023-08-15 10:17:42.071 INFO tokio-runtime-worker xcm::ethereum_blob_exporter: [Parachain] 🤩 converting.

The fee part is not correctly handled yet but agree as you mentioned we can focus on the basic flow as first step.

parachain/primitives/router/src/outbound/mod.rs

rust-toolchain.toml

parachain/primitives/router/src/outbound/mod.rs

alistair-singh · 2023-08-16T23:39:53Z

parachain/primitives/router/src/outbound/mod.rs

 		Ok(execution_fee)
 	}

+	fn is_transact(&self) -> bool {
+		for instruction in self.iter.clone() {


Instead of cloning the iterator, it might make sense to use Peekable iterator. This will allow peeking of the next instruction without advancing the iterator.

If I understand Peekable, it only looks one message ahead, and to move the cursor you have to call iter.next(). I am looking for message Transact, and at this point the next message is DescendOrigin (if that is even correct).

So I wrote this conversion code in recursive descendant parser style. Basically, you should only need to peek one instruction to decide which branch to go down.

The two branches here are whether to do a transact or a token unlock. So how I would use peek would be instead of this code, I would use the following psuedo code:

let result = match iter.peek() { DescendOrigin => transact_message(), // This must be a transact because we peeked DescendOrigin WithdrawAsset => native_tokens_unlock_message(), // This must be a token unlock because we peeked WithdrawAsset ReserveAssetDeposited => polkadot_token_burn_message(), // This doesnt exist yet, but will once we support polkadot assets _ => return Error::UnexpectedInstruction, // The peeked instruction is unknown so we fail because we didnt expect the instruction }

Then inside transact_message() you would consume whatever you need from DescendOrigin, then advance the iterator, and then match Transact. If you cant match transact at this point you fail with Error::UnexpectedInstruction. But in this case you know that your expecting transact so a better error name to use would be Error::TransactExpected.

parachain/primitives/router/src/outbound/mod.rs

alistair-singh · 2023-08-21T07:51:33Z

parachain/primitives/router/src/outbound/mod.rs

+		log::trace!(target: "xcm::ethereum_blob_exporter", "before transact.");
+
+		let data = if let Transact {
+			origin_kind: _origin_kind,


We might want to assert origin_kind is OriginKind::SovereignAccount because execution on an agent is the same as executing using a sovereign account.

Addressed in 6b3b09d.

claravanstaden · 2023-08-22T19:53:45Z

smoketest/tests/transact_polkadot_to_ethereum.rs

+
+    let inner_message = Box::new(Xcm(vec![
+        Instruction::UnpaidExecution { weight_limit: Unlimited, check_origin: None },// TODO update to paid
+        Instruction::DescendOrigin(contract_location), // TODO not sure if this is right, want to pass the contract address


@alistair-singh the Transact instruction doesn't have a field to specify the contract to be executed on Ethereum. Is DescendOrigin an OK way to send across the address of the arbitrary contract to be executed?

We do not need to use DescendOrigin and SetTopic here. The Xcm we should send and match should simply be:

UnpaidExecution { ... } Transact { ... }

The contract address needs to be passed call field using (address, function_selector, params). You already have (function_selector, params) implemented so just prepend the target contract address.

yrong · 2023-08-24T01:38:43Z

@claravanstaden For the issue you mentioned yesterday I just made a fix in 5db9786 and the smoke test shows e2e flow work as expected.

…hains' into clara/transact-on-polkadot-parachains

alistair-singh · 2023-08-24T18:26:59Z

smoketest/tests/transact_polkadot_to_ethereum.rs

+
+    let inner_message = Box::new(Xcm(vec![
+        Instruction::UnpaidExecution { weight_limit: Unlimited, check_origin: None },// TODO update to paid
+        Instruction::DescendOrigin(contract_location), // TODO not sure if this is right, want to pass the contract address


We do not need to use DescendOrigin and SetTopic here. The Xcm we should send and match should simply be:

UnpaidExecution { ... } Transact { ... }

The contract address needs to be passed call field using (address, function_selector, params). You already have (function_selector, params) implemented so just prepend the target contract address.

alistair-singh · 2023-08-24T18:31:49Z

smoketest/tests/transact_polkadot_to_ethereum.rs

+    });
+
+    let inner_message = Box::new(Xcm(vec![ // TODO send the Ethereum gas fee here too
+        Instruction::UnpaidExecution { weight_limit: Unlimited, check_origin: None },// TODO update to paid


This UnpaidExecution is for buying execution on the destination chain i.e. Ethereum. We do not support buying of execution on Ethereum so we use the unpaid execution right now. Execution is paid for currently by the channels agent who rewards the relayer for relaying the message.

We could potentially buy execution on the target by matching the below xcm:

WithdrawAsset (ETH, 1000) BuyExecution (ETH)

The code already can match this, however, we assert the execution is unpaid currently.

alistair-singh · 2023-08-24T18:46:57Z

parachain/primitives/router/src/outbound/mod.rs

 		Ok(execution_fee)
 	}

+	fn is_transact(&self) -> bool {
+		for instruction in self.iter.clone() {


So I wrote this conversion code in recursive descendant parser style. Basically, you should only need to peek one instruction to decide which branch to go down.

The two branches here are whether to do a transact or a token unlock. So how I would use peek would be instead of this code, I would use the following psuedo code:

let result = match iter.peek() { DescendOrigin => transact_message(), // This must be a transact because we peeked DescendOrigin WithdrawAsset => native_tokens_unlock_message(), // This must be a token unlock because we peeked WithdrawAsset ReserveAssetDeposited => polkadot_token_burn_message(), // This doesnt exist yet, but will once we support polkadot assets _ => return Error::UnexpectedInstruction, // The peeked instruction is unknown so we fail because we didnt expect the instruction }

Then inside transact_message() you would consume whatever you need from DescendOrigin, then advance the iterator, and then match Transact. If you cant match transact at this point you fail with Error::UnexpectedInstruction. But in this case you know that your expecting transact so a better error name to use would be Error::TransactExpected.

contracts/src/Gateway.sol

claravanstaden · 2024-02-20T10:21:13Z

Closing, will be re-done in SNO-866.

yrong reviewed Aug 10, 2023

View reviewed changes

parachain/primitives/core/src/outbound.rs Outdated Show resolved Hide resolved

yrong reviewed Aug 10, 2023

View reviewed changes

contracts/src/AgentExecutor.sol Outdated Show resolved Hide resolved

claravanstaden force-pushed the clara/transact-on-polkadot-parachains branch from 9339348 to c9ce72b Compare August 11, 2023 09:01

yrong reviewed Aug 13, 2023

View reviewed changes

parachain/primitives/router/src/outbound/mod.rs Outdated Show resolved Hide resolved

claravanstaden added the do-not-merge label Aug 14, 2023

claravanstaden changed the title ~~Transact on Parachains~~ Send messages from Polkadot to Ethereum contracts Aug 14, 2023

claravanstaden mentioned this pull request Aug 14, 2023

Send messages from Polkadot to Ethereum contracts Snowfork/cumulus#57

Draft

claravanstaden commented Aug 16, 2023

View reviewed changes

parachain/primitives/router/src/outbound/mod.rs Outdated Show resolved Hide resolved

claravanstaden commented Aug 16, 2023

View reviewed changes

parachain/primitives/router/src/outbound/mod.rs Show resolved Hide resolved

claravanstaden commented Aug 16, 2023

View reviewed changes

parachain/primitives/router/src/outbound/mod.rs Outdated Show resolved Hide resolved

yrong reviewed Aug 16, 2023

View reviewed changes

rust-toolchain.toml Show resolved Hide resolved

yrong reviewed Aug 16, 2023

View reviewed changes

parachain/primitives/router/src/outbound/mod.rs Outdated Show resolved Hide resolved

claravanstaden force-pushed the clara/transact-on-polkadot-parachains branch from 0104666 to 7d07acf Compare August 17, 2023 08:08

alistair-singh reviewed Aug 17, 2023

View reviewed changes

alistair-singh reviewed Aug 21, 2023

View reviewed changes

claravanstaden commented Aug 22, 2023

View reviewed changes

yrong and others added 11 commits August 22, 2023 22:03

Create/Update channel & Disable inbound channel

1747bfe

Revert "Create/Update channel & Disable inbound channel"

e7ba4ea

Add smoke tests for xcm based control extrinsic

70cbda5

Use template node for xcm tests

7e9ac3c

start with transact

0faa56d

call contract with dynamicGas

460385c

adds transact type

38af307

Fix test.

7b33b07

Remove dispatchGas from message type as it is part of the message.

8e69f27

Adds gas check, fix clippy.

9d59359

Adds gas error.

5c5c9b7

claravanstaden and others added 15 commits August 23, 2023 09:15

Adds BridgeXcmSender to template parachain.

23a5037

Fix export test

da0337a

Fix clippy error

9ab1cc5

Router progress

a81abcd

Router progress.

e366f2a

Message is queued and processed.

8f55a28

Adds Ethereum network to message.

3a6bd22

Adds relayer for template parachain.

aee1d7e

fix faulty launch config

7c5e648

Almost there.

6524a96

cleanup, contract creation works

fb0244b

create agent and channel in start-services

9339f7b

check sovereign account

b367a12

Adds test for agent execute transact.

5a36315

Fix things after rebase.

22c8d69

claravanstaden force-pushed the clara/transact-on-polkadot-parachains branch from 2577727 to 22c8d69 Compare August 23, 2023 10:00

clippy

3bfa1d8

claravanstaden changed the title ~~Send messages from Polkadot to Ethereum contracts~~ Arbitrary call from Polkadot to Ethereum contract Aug 23, 2023

Fix decode error & some polish

5db9786

claravanstaden added 4 commits August 24, 2023 13:28

Fixes and cleanup.

82bb265

Merge remote-tracking branch 'origin/clara/transact-on-polkadot-parac…

1f400fe

…hains' into clara/transact-on-polkadot-parachains

gas check and test improvements

e1af627

Cleanup computeGas function

286491d

alistair-singh reviewed Aug 24, 2023

View reviewed changes

yrong reviewed Aug 28, 2023

View reviewed changes

contracts/src/Gateway.sol Show resolved Hide resolved

Adds contract address before arbitrary bytes.

43935b6

claravanstaden mentioned this pull request Aug 29, 2023

Implement fees in outbound router since it is not supported #941

Closed

claravanstaden closed this Feb 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arbitrary call from Polkadot to Ethereum contract #924

Arbitrary call from Polkadot to Ethereum contract #924

claravanstaden commented Aug 8, 2023 •

edited

Loading

codecov bot commented Aug 8, 2023 •

edited

Loading

claravanstaden commented Aug 14, 2023 •

edited

Loading

yrong commented Aug 15, 2023 •

edited

Loading

alistair-singh Aug 16, 2023

claravanstaden Aug 21, 2023

alistair-singh Aug 24, 2023

alistair-singh Aug 21, 2023 •

edited

Loading

claravanstaden Aug 22, 2023

claravanstaden Aug 22, 2023

alistair-singh Aug 24, 2023 •

edited

Loading

yrong commented Aug 24, 2023

alistair-singh Aug 24, 2023 •

edited

Loading

alistair-singh Aug 24, 2023 •

edited

Loading

alistair-singh Aug 24, 2023

claravanstaden commented Feb 20, 2024

Arbitrary call from Polkadot to Ethereum contract #924

Arbitrary call from Polkadot to Ethereum contract #924

Conversation

claravanstaden commented Aug 8, 2023 • edited Loading

codecov bot commented Aug 8, 2023 • edited Loading

Codecov Report

claravanstaden commented Aug 14, 2023 • edited Loading

yrong commented Aug 15, 2023 • edited Loading

alistair-singh Aug 16, 2023

Choose a reason for hiding this comment

claravanstaden Aug 21, 2023

Choose a reason for hiding this comment

alistair-singh Aug 24, 2023

Choose a reason for hiding this comment

alistair-singh Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

claravanstaden Aug 22, 2023

Choose a reason for hiding this comment

claravanstaden Aug 22, 2023

Choose a reason for hiding this comment

alistair-singh Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

yrong commented Aug 24, 2023

alistair-singh Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

alistair-singh Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

alistair-singh Aug 24, 2023

Choose a reason for hiding this comment

claravanstaden commented Feb 20, 2024

claravanstaden commented Aug 8, 2023 •

edited

Loading

codecov bot commented Aug 8, 2023 •

edited

Loading

claravanstaden commented Aug 14, 2023 •

edited

Loading

yrong commented Aug 15, 2023 •

edited

Loading

alistair-singh Aug 21, 2023 •

edited

Loading

alistair-singh Aug 24, 2023 •

edited

Loading

alistair-singh Aug 24, 2023 •

edited

Loading

alistair-singh Aug 24, 2023 •

edited

Loading