Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log command name when loading fails #147

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Log command name when loading fails #147

merged 2 commits into from
Jul 6, 2024

Conversation

flut2
Copy link
Contributor

@flut2 flut2 commented Jun 24, 2024

No description provided.

@flut2
Copy link
Contributor Author

flut2 commented Jul 6, 2024

Some explanations on why I think this is might be needed: command loading is done with an inline for, something which debuggers don't seem to capture properly (or I just don't know of one that does), leading to the exact command failing being unknown.
This often isn't an issue when developers check for extensions they'd like to use, but in my case I ran into the issue of RenderDoc not supporting Wayland windows which I only managed to realize after checking which commands fail.

@Snektron Snektron merged commit 66b7b77 into Snektron:master Jul 6, 2024
1 check passed
@Snektron
Copy link
Owner

Snektron commented Jul 6, 2024

Hi, I was already convinced, I'm just bad at keeping up with merge requests. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flut2 @Snektron