[Triangle Example] Fix crash when minimizing window #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for the device to be idle before exiting
Sirius902
force-pushed
the
minimize-fix
branch
from
fe17f7f to
e3bc661
Compare
|
I forgot that windows does this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when minimizing the window in the triangle example due to the window size becoming zero as well as two minor changes. Also changes the swapchain to use the GLFW framebuffer size instead of the window size as iirc they can differ and the swapchain expects the framebuffer size since both operate in pixels.
Edit: Added a
deviceWaitIdlecall before the program exits since I got Vulkan validation errors about semaphores being deleted while still in use with the validation layer enabled.